From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: netdev@vger.kernel.org, lucy.liu@intel.com,
john.r.fastabend@intel.com, alexander.h.duyck@intel.com
Subject: Re: [PATCH 0/8] dcbnl: Major simplifications
Date: Wed, 13 Jun 2012 15:55:41 -0700 (PDT) [thread overview]
Message-ID: <20120613.155541.26513304496438357.davem@davemloft.net> (raw)
In-Reply-To: <cover.1339591572.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 13 Jun 2012 14:54:53 +0200
> The dcbnl code is overly complicated when constructing the reply
> message. This series of patches simplifies the process and
> introduces consistent error codes allowing user space to figure
> out what went wrong.
>
> Patches have been tested with ixgbe in a FCoE setup.
>
> Thomas Graf (8):
> dcbnl: Prepare framework to shorten handling functions
> dcbnl: Shorten all command handling functions
> dcbnl: Remove now unused dcbnl_reply()
> dcbnl: Use dcbnl_newmsg() where possible
> dcbnl: Return consistent error codes
> dcbnl: Move dcb app lookup code into dcb_app_lookup()
> dcbnl: Move dcb app allocation into dcb_app_add()
> dcbnl: Use type safe nlmsg_data()
Lots of deleted code, I like it :-)
Applied, but could you send a follow-on patch to use BUG_ON() instead
of that "if (!ptr) { /* ... */ BUG(); }" construct?
Thanks.
next prev parent reply other threads:[~2012-06-13 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 12:54 [PATCH 0/8] dcbnl: Major simplifications Thomas Graf
2012-06-13 12:54 ` [PATCH 1/8] dcbnl: Prepare framework to shorten handling functions Thomas Graf
2012-06-13 12:54 ` [PATCH 2/8] dcbnl: Shorten all command " Thomas Graf
2012-06-21 6:04 ` John Fastabend
2012-06-13 12:54 ` [PATCH 3/8] dcbnl: Remove now unused dcbnl_reply() Thomas Graf
2012-06-13 12:54 ` [PATCH 4/8] dcbnl: Use dcbnl_newmsg() where possible Thomas Graf
2012-06-13 12:54 ` [PATCH 5/8] dcbnl: Return consistent error codes Thomas Graf
2012-06-13 12:54 ` [PATCH 6/8] dcbnl: Move dcb app lookup code into dcb_app_lookup() Thomas Graf
2012-06-13 12:55 ` [PATCH 7/8] dcbnl: Move dcb app allocation into dcb_app_add() Thomas Graf
2012-06-13 12:55 ` [PATCH 8/8] dcbnl: Use type safe nlmsg_data() Thomas Graf
2012-06-13 22:55 ` David Miller [this message]
2012-06-14 7:54 ` [PATCH 0/8] dcbnl: Major simplifications Thomas Graf
2012-06-14 16:06 ` John Fastabend
2012-06-15 7:26 ` Thomas Graf
2012-06-16 3:53 ` John Fastabend
2012-06-14 8:40 ` [PATCH] dcbnl: Use BUG_ON() instead of BUG() Thomas Graf
2012-06-14 8:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613.155541.26513304496438357.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=lucy.liu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).