netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] ipv4: Kill ip_rt_frag_needed().
Date: Wed, 13 Jun 2012 23:54:25 -0700 (PDT)	[thread overview]
Message-ID: <20120613.235425.582674313518085400.davem@davemloft.net> (raw)
In-Reply-To: <20120614063632.GS27795@secunet.com>

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 14 Jun 2012 08:36:32 +0200

> On Wed, Jun 13, 2012 at 10:59:41PM -0700, David Miller wrote:
>> 
>> Actually, thinking some more, we could extend my inet->pmtudisc patch
>> to achieve a similar effect.
>> 
>> Essentially we'd have a socket local PMTU value for datagram sockets.
>> 
>> Would you be OK with that approach?
> 
> This would require to maintain socket local pmtu expire times too.
> Also, which of these pmtu values do we report if a user asks for
> that? And how should we flush all these pmtu values?
> 
> It could have some side effects. But if we get it to work,
> it would be an improvement. I'm fine with everything
> that works in the end :-)

Your right, maybe the route updating approach is therefore better.

I'll play around with my original patch.

Thanks.

      reply	other threads:[~2012-06-14  6:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11  9:29 [PATCH 2/5] ipv4: Kill ip_rt_frag_needed() David Miller
2012-06-11 11:16 ` Steffen Klassert
2012-06-11 11:20   ` David Miller
2012-06-11 11:28     ` David Miller
2012-06-11 11:42       ` Steffen Klassert
2012-06-11 23:02         ` David Miller
2012-06-12 11:44           ` Steffen Klassert
2012-06-12 20:33             ` David Miller
2012-06-13  4:22               ` David Miller
2012-06-13  8:01               ` Steffen Klassert
2012-06-13  9:42                 ` David Miller
2012-06-13 10:07                   ` Steffen Klassert
2012-06-13 10:22                     ` David Miller
2012-06-14  5:35                       ` Steffen Klassert
2012-06-14  5:42                         ` David Miller
2012-06-14  5:58                           ` Steffen Klassert
2012-06-14  5:59                           ` David Miller
2012-06-14  6:36                             ` Steffen Klassert
2012-06-14  6:54                               ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613.235425.582674313518085400.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).