Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: Prevent access to uninitialized fib_table_hash via /proc/net/ipv6_route
Date: Sat, 16 Jun 2012 01:13:30 -0700 (PDT)	[thread overview]
Message-ID: <20120616.011330.636639748049380489.davem@davemloft.net> (raw)
In-Reply-To: <20120615.221502.1196734470412725503.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Fri, 15 Jun 2012 22:15:02 -0700 (PDT)

> We will now initialize fib6_init() before ip6_net_route_net_ops is registerd.
> 
> This causes fib6_net_init() to run before net->ipv6.ip6_null_entry it
> initialized.
> 
> Any route lookup will crash when we dereference a root's ->leaf
> because it will be NULL.

I've decided to revert this change for now.

  reply	other threads:[~2012-06-16  8:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15  9:00 [PATCH] ipv6: Prevent access to uninitialized fib_table_hash via /proc/net/ipv6_route Thomas Graf
2012-06-15 10:56 ` Neil Horman
2012-06-15 22:32   ` David Miller
2012-06-16  5:15     ` David Miller
2012-06-16  8:13       ` David Miller [this message]
2012-06-16 13:07       ` Neil Horman
2012-06-16 22:22         ` David Miller
2012-06-17  6:11       ` Thomas Graf
2012-06-19 11:36     ` Thomas Graf
2012-06-19 21:13       ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2012-06-16  9:46 Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120616.011330.636639748049380489.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox