From: David Miller <davem@davemloft.net>
To: sfking@fdwdc.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3] fec: fix clk handling for Coldfire.
Date: Sun, 17 Jun 2012 16:47:04 -0700 (PDT) [thread overview]
Message-ID: <20120617.164704.225704951627971907.davem@davemloft.net> (raw)
In-Reply-To: <201206171639.43651.sfking@fdwdc.com>
From: Steven King <sfking@fdwdc.com>
Date: Sun, 17 Jun 2012 16:39:43 -0700
> commit f4d40de39a23f0c39cca55ac63e1175c69c3d2f7
> 'net fec: do not depend on grouped clocks' broke fec for Coldfire.
>
> Hide the details of the fec clk management in a trio of new functions:
> fec_clk_get, fec_clk_prepare and fec_clk_disable_unprepare. these then can
> be modified as needed to manage the clks for the different arches that use
> the fec controller.
>
> Signed-off-by: Steven King <sfking@fdwdc.com>
I said keep the ifdefs out of the foo.c code.
Put this ifdef'y into one of the driver's header files, such
as fec.h
prev parent reply other threads:[~2012-06-17 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 23:39 [PATCH v3] fec: fix clk handling for Coldfire Steven King
2012-06-17 23:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120617.164704.225704951627971907.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sfking@fdwdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox