From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
netdev@vger.kernel.org, dotanb@mellanox.co.il,
Or Gerlitz <ogerlitz@mellanox.com>,
yevgenyp@mellanox.co.il
Subject: Re: mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet
Date: Sun, 17 Jun 2012 18:18:05 +0300 [thread overview]
Message-ID: <201206171818.05299.jackm@dev.mellanox.co.il> (raw)
In-Reply-To: <1339290217.21665.164.camel@deadeye.wl.decadent.org.uk>
On Sunday 10 June 2012 04:03, Ben Hutchings wrote:
> It would be more idiomatic to write the condition as:
>
> if (hca_param.global_caps & ~(u64)HCA_GLOBAL_CAP_MASK)
>
> (although that cast probably belongs in the definition of
> HCA_GLOBAL_CAP_MASK).
>
You are correct!
We need to submit a patch to fix this.
-Jack
prev parent reply other threads:[~2012-06-17 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 9:09 mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet Dan Carpenter
2012-06-09 11:29 ` Jack Morgenstein
2012-06-10 1:03 ` Ben Hutchings
2012-06-17 15:18 ` Jack Morgenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206171818.05299.jackm@dev.mellanox.co.il \
--to=jackm@dev.mellanox.co.il \
--cc=bhutchings@solarflare.com \
--cc=dan.carpenter@oracle.com \
--cc=dotanb@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox