From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: parav.pandit@emulex.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: added support for 40GbE link.
Date: Tue, 19 Jun 2012 00:29:05 -0700 (PDT) [thread overview]
Message-ID: <20120619.002905.922583388766089167.davem@davemloft.net> (raw)
In-Reply-To: <1340039376.2913.13.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 18 Jun 2012 18:09:36 +0100
> On Mon, 2012-06-18 at 18:14 +0530, Parav Pandit wrote:
...
>> -/* The forced speed, 10Mb, 100Mb, gigabit, 2.5Gb, 10GbE. */
>> +/* The forced speed, 10Mb, 100Mb, gigabit, 2.5Gb, 10GbE, 40GbE. */
>
> I don't think there's any need to name all possible link speeds, and it
> just encourages the bad practice of ethtool API users checking for
> specific values. You may notice there is no SPEED_20000.
Agreed.
>> @@ -542,13 +542,11 @@ static int prb_calc_retire_blk_tmo(struct packet_sock *po,
...
> This function should be fixed properly. Firstly, it must use
> ethtool_cmd_speed() rather than directly accessing ecmd.speed.
> Secondly, it should allow any speed value rather than checking for
> specific values. Then there will be no need to make further changes for
> 100G or any other new speed.
Agreed.
next prev parent reply other threads:[~2012-06-19 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 12:44 [PATCH] net: added support for 40GbE link Parav Pandit
2012-06-18 16:27 ` Rick Jones
2012-06-18 16:56 ` Ben Hutchings
2012-06-19 5:20 ` Parav.Pandit
2012-06-18 17:09 ` Ben Hutchings
2012-06-19 7:29 ` David Miller [this message]
2012-06-19 7:33 ` Parav.Pandit
2012-06-19 7:35 ` David Miller
2012-06-19 7:42 ` Parav.Pandit
2012-06-19 14:11 ` Ben Hutchings
2012-06-27 9:08 ` Parav.Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619.002905.922583388766089167.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=parav.pandit@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox