From: David Miller <davem@davemloft.net>
To: jason77.wang@gmail.com
Cc: david.choi@micrel.com, nobuhiro.iwamatsu.yj@renesas.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] phy/micrel: change phy_id_mask for KSZ9021 and KS8001
Date: Tue, 19 Jun 2012 00:31:57 -0700 (PDT) [thread overview]
Message-ID: <20120619.003157.1182913417516661199.davem@davemloft.net> (raw)
In-Reply-To: <1340009529-4231-1-git-send-email-jason77.wang@gmail.com>
From: Hui Wang <jason77.wang@gmail.com>
Date: Mon, 18 Jun 2012 16:52:09 +0800
> On a freescale imx6q platform, a hardware phy chip KSZ9021 is
> recognized as a KS8001 chip by the current driver like this:
> eth0: Freescale FEC PHY driver [Micrel KS8001 or KS8721]
>
> KSZ9021 has phy_id 0x00221610, while KSZ8001 has phy_id
> 0x0022161a, the current phy_id_mask (0x00fffff0/0x00ffff10) can't
> distinguish them. So change phy_id_mask to resolve this problem.
>
> Although the micrel datasheet says that the 4 LSB of phyid2 register
> contains the chip revision number and the current driver is designed
> to follow this rule, in reality the chip implementation doesn't follow
> it.
>
> Cc: David J. Choi <david.choi@micrel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2012-06-19 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 8:52 [PATCH] phy/micrel: change phy_id_mask for KSZ9021 and KS8001 Hui Wang
2012-06-19 7:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619.003157.1182913417516661199.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.choi@micrel.com \
--cc=jason77.wang@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox