From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 02.5] mm: sl[au]b: first remove PFMEMALLOC flag then SLAB flag Date: Wed, 20 Jun 2012 08:38:05 +0100 Message-ID: <20120620073805.GD8810@suse.de> References: <1337266231-8031-1-git-send-email-mgorman@suse.de> <1337266231-8031-3-git-send-email-mgorman@suse.de> <20120615155432.GA5498@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: Andrew Morton , Linux-MM , Linux-Netdev , LKML , David Miller , Neil Brown , Peter Zijlstra , Mike Christie , Eric B Munson To: Sebastian Andrzej Siewior Return-path: Content-Disposition: inline In-Reply-To: <20120615155432.GA5498@breakpoint.cc> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Fri, Jun 15, 2012 at 05:54:32PM +0200, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > > If we first remove the SLAB flag followed by the PFMEMALLOC flag then the > removal of the latter will trigger the VM_BUG_ON() as it can be seen in > | kernel BUG at include/linux/page-flags.h:474! > | invalid opcode: 0000 [#1] PREEMPT SMP > | Call Trace: > | [] slab_destroy+0x27/0x70 > | [] drain_freelist+0x55/0x90 > | [] __cache_shrink+0x6e/0x90 > | [] ? acpi_sleep_init+0xcf/0xcf > | [] kmem_cache_shrink+0x2d/0x40 > > because the SLAB flag is gone. This patch simply changes the order. > > Signed-off-by: Sebastian Andrzej Siewior Grr, yes of course. Thanks very much. I've folded this into patch 2 and preserved credit. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org