From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB Date: Wed, 20 Jun 2012 10:00:21 +0200 Message-ID: <201206201000.21845.oneukum@suse.de> References: <201206180923.36091.oneukum@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Huajun Li Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am Montag, 18. Juni 2012, 18:25:15 schrieb Huajun Li: > On Mon, Jun 18, 2012 at 3:23 PM, Oliver Neukum wrote: > > Am Montag, 18. Juni 2012, 01:30:17 schrieb David Miller: > >> From: Huajun Li > >> Date: Wed, 13 Jun 2012 20:50:31 +0800 > >> > >> > intr_complete() submits URB even the interrupt endpoint stalls. > >> > This patch will try to activate the endpoint once the exception > >> > occurs, and then re-submit the URB if the endpoint works again. > >> > > >> > Signed-off-by: Huajun Li > >> > >> Review from USB experts would be appreciated. > > > > The code implements a minimum error handler correctly. > > Did you observe a stall in actual hardware or is this a just > > in case patch? > > > > This one is just a patch, thanks for your comments. Very well, on second thought, this patch makes sense. Could you resend and I'll ack? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html