next-20120620 build error in netfilter

next-20120620 build error in netfilter

[Valdis Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m

  LD      init/built-in.o
net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust'
make: *** [vmlinux] Error 1

Breakage introduced with this commit:

commit 8c88f87cb27ad09086940bdd3e6955e5325ec89a
Author: Pablo Neira Ayuso <pablo@netfilter.org>
Date:   Thu Jun 7 13:31:25 2012 +0200

    netfilter: nfnetlink_queue: add NAT TCP sequence adjustment if packet mangled


[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]

Re: next-20120620 build error in netfilter

[Pablo Neira Ayuso]

On Wed, Jun 20, 2012 at 01:14:33PM -0400, Valdis Kletnieks wrote:
> Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m
> 
>   LD      init/built-in.o
> net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust'
> make: *** [vmlinux] Error 1

I guess you have NF_CT_NETLINK=y, right?

> Breakage introduced with this commit:
> 
> commit 8c88f87cb27ad09086940bdd3e6955e5325ec89a
> Author: Pablo Neira Ayuso <pablo@netfilter.org>
> Date:   Thu Jun 7 13:31:25 2012 +0200
> 
>     netfilter: nfnetlink_queue: add NAT TCP sequence adjustment if packet mangled
> 

Re: next-20120620 build error in netfilter

[valdis.kletnieks]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

On Wed, 20 Jun 2012 19:28:01 +0200, Pablo Neira Ayuso said:
> On Wed, Jun 20, 2012 at 01:14:33PM -0400, Valdis Kletnieks wrote:
> > Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m
> >
> >   LD      init/built-in.o
> > net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust'
> > make: *** [vmlinux] Error 1
>
> I guess you have NF_CT_NETLINK=y, right?

Yes.

Temporary workaround was setting NF_NAT=n (I don't use NAT, I just usually
build all the netfilter modules as =m even if I don't use them, just to provide
build coverage and trip over stuff like this).


[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]

Re: next-20120620 build error in netfilter

[Pablo Neira Ayuso]

On Wed, Jun 20, 2012 at 02:37:52PM -0400, valdis.kletnieks@vt.edu wrote:
> On Wed, 20 Jun 2012 19:28:01 +0200, Pablo Neira Ayuso said:
> > On Wed, Jun 20, 2012 at 01:14:33PM -0400, Valdis Kletnieks wrote:
> > > Today's linux-next fails to build with CONFIG_NF_NAT_NEEDED=y and CONFIG_NF_NAT=m
> > >
> > >   LD      init/built-in.o
> > > net/built-in.o:(.data+0x4408): undefined reference to `nf_nat_tcp_seq_adjust'
> > > make: *** [vmlinux] Error 1
> >
> > I guess you have NF_CT_NETLINK=y, right?
> 
> Yes.
> 
> Temporary workaround was setting NF_NAT=n (I don't use NAT, I just usually
> build all the netfilter modules as =m even if I don't use them, just to provide
> build coverage and trip over stuff like this).

Probably NF_CT_NETLINK=m is a better workaround.

Anyway, I've enqueued the following patch to fix this:

http://1984.lsi.us.es/git/nf-next/commit/?id=d584a61a931e6cbfef0dd811c4ae0250ec5987f4

So you can use your previous config.

Thanks.