From: Thomas Graf <tgraf@suug.ch>
To: John Fastabend <john.r.fastabend@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, lucy.liu@intel.com,
alexander.h.duyck@intel.com
Subject: Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()
Date: Thu, 21 Jun 2012 06:52:45 -0400 [thread overview]
Message-ID: <20120621105245.GI27921@canuck.infradead.org> (raw)
In-Reply-To: <20120621055621.14148.42206.stgit@jf-dev1-dcblab>
On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
>
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@suug.ch>
> Date: Wed Jun 13 02:54:55 2012 +0000
>
> dcbnl: Shorten all command handling functions
>
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2012-06-21 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 5:56 [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg() John Fastabend
2012-06-21 8:19 ` Thomas Graf
2012-06-21 9:04 ` David Miller
2012-06-21 10:52 ` Thomas Graf [this message]
2012-06-21 22:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621105245.GI27921@canuck.infradead.org \
--to=tgraf@suug.ch \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=lucy.liu@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).