* [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()
@ 2012-06-21 5:56 John Fastabend
2012-06-21 8:19 ` Thomas Graf
2012-06-21 10:52 ` Thomas Graf
0 siblings, 2 replies; 5+ messages in thread
From: John Fastabend @ 2012-06-21 5:56 UTC (permalink / raw)
To: tgraf, davem; +Cc: netdev, lucy.liu, alexander.h.duyck
A small regression was introduced in the reply command of
dcbnl_pg_setcfg(). User space apps may be expecting the
DCB_ATTR_PG_CFG attribute to be returned with the patch
below TX or RX variants are returned.
commit 7be994138b188387691322921c08e19bddf6d3c5
Author: Thomas Graf <tgraf@suug.ch>
Date: Wed Jun 13 02:54:55 2012 +0000
dcbnl: Shorten all command handling functions
This patch reverts this behavior and returns DCB_ATTR_PG_CFG
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/dcb/dcbnl.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 0a36007..013da86 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
}
}
- return nla_put_u8(skb,
- (dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
+ return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
}
static int dcbnl_pgtx_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()
2012-06-21 5:56 [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg() John Fastabend
@ 2012-06-21 8:19 ` Thomas Graf
2012-06-21 9:04 ` David Miller
2012-06-21 10:52 ` Thomas Graf
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Graf @ 2012-06-21 8:19 UTC (permalink / raw)
To: John Fastabend; +Cc: tgraf, davem, netdev, lucy.liu, alexander.h.duyck
On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
>
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@suug.ch>
> Date: Wed Jun 13 02:54:55 2012 +0000
>
> dcbnl: Shorten all command handling functions
>
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> ---
>
> net/dcb/dcbnl.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> index 0a36007..013da86 100644
> --- a/net/dcb/dcbnl.c
> +++ b/net/dcb/dcbnl.c
> @@ -852,8 +852,7 @@ static int __dcbnl_pg_setcfg(struct net_device *netdev, struct nlmsghdr *nlh,
> }
> }
>
> - return nla_put_u8(skb,
> - (dir ? DCB_CMD_PGRX_SCFG : DCB_CMD_PGTX_SCFG), 0);
> + return nla_put_u8(skb, DCB_ATTR_PG_CFG, 0);
> }
>
ACK
Thanks John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()
2012-06-21 5:56 [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg() John Fastabend
2012-06-21 8:19 ` Thomas Graf
@ 2012-06-21 10:52 ` Thomas Graf
2012-06-21 22:06 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Graf @ 2012-06-21 10:52 UTC (permalink / raw)
To: John Fastabend; +Cc: davem, netdev, lucy.liu, alexander.h.duyck
On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
> A small regression was introduced in the reply command of
> dcbnl_pg_setcfg(). User space apps may be expecting the
> DCB_ATTR_PG_CFG attribute to be returned with the patch
> below TX or RX variants are returned.
>
> commit 7be994138b188387691322921c08e19bddf6d3c5
> Author: Thomas Graf <tgraf@suug.ch>
> Date: Wed Jun 13 02:54:55 2012 +0000
>
> dcbnl: Shorten all command handling functions
>
> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg()
2012-06-21 10:52 ` Thomas Graf
@ 2012-06-21 22:06 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-06-21 22:06 UTC (permalink / raw)
To: tgraf; +Cc: john.r.fastabend, netdev, lucy.liu, alexander.h.duyck
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 21 Jun 2012 06:52:45 -0400
> On Wed, Jun 20, 2012 at 10:56:21PM -0700, John Fastabend wrote:
>> A small regression was introduced in the reply command of
>> dcbnl_pg_setcfg(). User space apps may be expecting the
>> DCB_ATTR_PG_CFG attribute to be returned with the patch
>> below TX or RX variants are returned.
>>
>> commit 7be994138b188387691322921c08e19bddf6d3c5
>> Author: Thomas Graf <tgraf@suug.ch>
>> Date: Wed Jun 13 02:54:55 2012 +0000
>>
>> dcbnl: Shorten all command handling functions
>>
>> This patch reverts this behavior and returns DCB_ATTR_PG_CFG
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>
> Acked-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-21 22:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21 5:56 [PATCH] net: dcb: fix small regression in __dcbnl_pg_setcfg() John Fastabend
2012-06-21 8:19 ` Thomas Graf
2012-06-21 9:04 ` David Miller
2012-06-21 10:52 ` Thomas Graf
2012-06-21 22:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).