From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Remove unnecessary code from rt_check_expire().
Date: Tue, 26 Jun 2012 01:56:12 -0700 (PDT) [thread overview]
Message-ID: <20120626.015612.985388265386248330.davem@davemloft.net> (raw)
In-Reply-To: <1340700408.10893.275.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 26 Jun 2012 10:46:48 +0200
> On Tue, 2012-06-26 at 01:37 -0700, David Miller wrote:
>
>> And think, we don't do any stupidity like this for the inetpeer cache
>> and no small cute animals have died as a result.
>
> Thats because inetpeer is kept small.
>
> We do have a smart gc on inetpeer cache (inet_peer_gc()),
> and inetpeer threshold is 65536
Fair enough.
Keep in mind that rt_check_expire() was written before we had realtime
GC. It used to be main component which kept hash chains of reasonable
size before real ->gc() triggers.
I have about 15 entries in my routing cache, there is no reason they
should be purged.
And consider TCP before early demux, so a connection doing financial
trades is idle for 5 minutes. Do you really think the next trade
should have this pointless added latency just because we can't be
bothered to make rt_check_expired() smarter?
next prev parent reply other threads:[~2012-06-26 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 7:21 [PATCH] ipv4: Remove unnecessary code from rt_check_expire() David Miller
2012-06-26 7:39 ` Eric Dumazet
2012-06-26 7:46 ` David Miller
2012-06-26 7:58 ` Eric Dumazet
2012-06-26 8:23 ` Eric Dumazet
2012-06-26 8:37 ` David Miller
2012-06-26 8:46 ` Eric Dumazet
2012-06-26 8:56 ` David Miller [this message]
2012-06-26 9:11 ` Eric Dumazet
2012-06-26 9:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626.015612.985388265386248330.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).