netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: alexander.h.duyck@intel.com, netdev@vger.kernel.org,
	gospo@redhat.com, sassmann@redhat.com, stable@vger.kernel.org
Subject: Re: [net] ixgbe: Do not pad FCoE frames as this can cause issues with FCoE DDP
Date: Tue, 26 Jun 2012 16:45:35 -0700 (PDT)	[thread overview]
Message-ID: <20120626.164535.1370104947946690268.davem@davemloft.net> (raw)
In-Reply-To: <1340697286-3047-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 26 Jun 2012 00:54:46 -0700

> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> FCoE target mode was experiencing issues due to the fact that we were
> sending up data frames that were padded to 60 bytes after the DDP logic had
> already stripped the frame down to 52 or 56 depending on the use of VLANs.
> This was resulting in the FCoE DDP logic having issues since it thought the
> frame still had data in it due to the padding.
> 
> To resolve this, adding code so that we do not pad FCoE frames prior to
> handling them to the stack.
> 
> CC: <stable@vger.kernel.org>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
> Tested-by: Ross Brattain <ross.b.brattain@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Applied, thanks.

  reply	other threads:[~2012-06-26 23:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  7:54 [net] ixgbe: Do not pad FCoE frames as this can cause issues with FCoE DDP Jeff Kirsher
2012-06-26 23:45 ` David Miller [this message]
     [not found] <1340696951-2686-1-git-send-email-jeffrey.t.kirsher@intel.com>
2012-06-26  7:50 ` David Miller
2012-06-26  7:53   ` Jeff Kirsher
2012-06-26 14:09     ` Ben Hutchings
2012-06-26 15:48       ` Alexander Duyck
2012-06-26 15:56         ` Ben Hutchings
     [not found] <1340695993-1911-1-git-send-email-jeffrey.t.kirsher@intel.com>
2012-06-26  7:43 ` David Miller
2012-06-26  7:47   ` Jeff Kirsher
2012-06-26 16:33     ` Greg KH
2012-06-26  7:49   ` Jeff Kirsher
2012-06-26  7:50     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626.164535.1370104947946690268.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexander.h.duyck@intel.com \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).