From: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
To: "Ren, Cloud" <cjren@qca.qualcomm.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <qca-linux-team@qualcomm.com>,
<nic-devel@qualcomm.com>, xiong <xiong@qca.qualcomm.com>
Subject: Re: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out
Date: Tue, 26 Jun 2012 11:03:11 -0700 [thread overview]
Message-ID: <20120626180311.GC5070@tux> (raw)
In-Reply-To: <1340724786-3819-1-git-send-email-cjren@qca.qualcomm.com>
On Tue, Jun 26, 2012 at 12:33:06PM -0300, Ren, Cloud wrote:
> From: xiong <xiong@qca.qualcomm.com>
>
> some people report atl1c could cause system hang with following
> kernel trace info:
> ---------------------------------------
> WARNING: at.../net/sched/sch_generic.c:258
> dev_watchdog+0x1db/0x1d0()
> ...
> NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out
> ...
> ---------------------------------------
> This is caused by netif_stop_queue calling when cable Link is down
> but netif_wake_queue isn't called when cable Link is resume.
>
> Signed-off-by: xiong <xiong@qca.qualcomm.com>
> Signed-off-by: Cloud Ren <cjren@qca.qualcomm.com>
If this fixes a system hang then this could be a stable
fix -- that is, this should be propagated to older stable
kernels, no?
If so then please add to the commit log a line like this:
Cc: stable@vger.kernel.org [3.4]
Note: this is for the commit log! Right above the line below
that has "---"
Luis
next prev parent reply other threads:[~2012-06-26 18:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 15:33 [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out Ren, Cloud
2012-06-26 18:03 ` Luis R. Rodriguez [this message]
2012-06-26 20:41 ` Huang, Xiong
2012-06-26 20:54 ` Luis R. Rodriguez
2012-06-26 20:55 ` Huang, Xiong
2012-06-26 20:23 ` Ben Hutchings
2012-06-26 20:25 ` Huang, Xiong
2012-06-26 20:26 ` Huang, Xiong
-- strict thread matches above, loose matches on Subject: below --
2012-07-03 13:27 Ren, Cloud
2012-07-03 10:23 ` David Miller
2012-07-03 13:04 ` Huang, Xiong
2012-07-04 1:56 ` Ren, Cloud
2012-07-04 2:51 cjren
2012-07-09 7:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626180311.GC5070@tux \
--to=rodrigue@qca.qualcomm.com \
--cc=cjren@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).