* [patch -next] 6lowpan: double unlock on an error path
@ 2012-06-27 6:53 Dan Carpenter
2012-06-27 6:57 ` Alexander Smirnov
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-06-27 6:53 UTC (permalink / raw)
To: Dmitry Eremin-Solenikov
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
David S. Miller
We already unlocked a few lines earlier here, so we can go directly to
drop without passing through unlock. This was introduced recently in
c5d3687f6c ('6lowpan: read data from skb safely').
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index ad0c226..cd5007f 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -771,7 +771,7 @@ lowpan_process_data(struct sk_buff *skb)
kfree(frame);
if (lowpan_fetch_skb_u8(skb, &iphc0))
- goto unlock_and_drop;
+ goto drop;
break;
}
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch -next] 6lowpan: double unlock on an error path
2012-06-27 6:53 [patch -next] 6lowpan: double unlock on an error path Dan Carpenter
@ 2012-06-27 6:57 ` Alexander Smirnov
2012-06-27 8:17 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Smirnov @ 2012-06-27 6:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dmitry Eremin-Solenikov, Sergey Lapin, David S. Miller,
linux-zigbee-devel, netdev, kernel-janitors
2012/6/27 Dan Carpenter <dan.carpenter@oracle.com>:
> We already unlocked a few lines earlier here, so we can go directly to
> drop without passing through unlock. This was introduced recently in
> c5d3687f6c ('6lowpan: read data from skb safely').
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> index ad0c226..cd5007f 100644
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -771,7 +771,7 @@ lowpan_process_data(struct sk_buff *skb)
> kfree(frame);
>
> if (lowpan_fetch_skb_u8(skb, &iphc0))
> - goto unlock_and_drop;
> + goto drop;
>
> break;
> }
Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch -next] 6lowpan: double unlock on an error path
2012-06-27 6:57 ` Alexander Smirnov
@ 2012-06-27 8:17 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-06-27 8:17 UTC (permalink / raw)
To: alex.bluesman.smirnov
Cc: dan.carpenter, dbaryshkov, slapin, linux-zigbee-devel, netdev,
kernel-janitors
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Date: Wed, 27 Jun 2012 10:57:18 +0400
> 2012/6/27 Dan Carpenter <dan.carpenter@oracle.com>:
>> We already unlocked a few lines earlier here, so we can go directly to
>> drop without passing through unlock. This was introduced recently in
>> c5d3687f6c ('6lowpan: read data from skb safely').
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
...
> Acked-by: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-27 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-27 6:53 [patch -next] 6lowpan: double unlock on an error path Dan Carpenter
2012-06-27 6:57 ` Alexander Smirnov
2012-06-27 8:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).