From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, hans.schillstrom@ericsson.com
Subject: Re: [PATCH net-next] ipv4: tcp: dont cache unconfirmed intput dst
Date: Wed, 27 Jun 2012 17:08:30 -0700 (PDT) [thread overview]
Message-ID: <20120627.170830.811332455348620174.davem@davemloft.net> (raw)
In-Reply-To: <20120627.170101.99084491660488389.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 27 Jun 2012 17:01:01 -0700 (PDT)
> There are quite a number of unwanted side effects from this change, so
> I think we'll have to revert unless you can fix up all of the relevant
> cases quickly.
Actually I've decided to revert it now.
Whilst this was a swell idea, there is no way for you to know if
we should really create a cached route or not.
Even if you could, there is a lot of logic you'll need to code up
so that, f.e., once we determine that we've got a DST_NOCACHE route
when we move to established state, we can insert it into the routing
cache and not mark it DST_NOCACHE any longer.
But even if we did that, we're going to eat 2 uncached route lookups
for every new incoming legitimate connection.
next prev parent reply other threads:[~2012-06-28 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 9:14 [PATCH net-next] ipv4: tcp: dont cache unconfirmed intput dst Eric Dumazet
2012-06-27 22:34 ` David Miller
2012-06-27 23:44 ` David Miller
2012-06-28 0:01 ` David Miller
2012-06-28 0:08 ` David Miller [this message]
2012-06-28 5:08 ` Eric Dumazet
2012-06-28 5:13 ` Eric Dumazet
2012-06-28 5:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627.170830.811332455348620174.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hans.schillstrom@ericsson.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).