From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, brouer@redhat.com,
mst@redhat.com
Subject: Re: [patch net-next] virtio_net: allow to change mac when iface is running
Date: Wed, 27 Jun 2012 21:30:46 -0700 (PDT) [thread overview]
Message-ID: <20120627.213046.1244710404799995026.davem@davemloft.net> (raw)
In-Reply-To: <1340810866-1017-1-git-send-email-jpirko@redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Wed, 27 Jun 2012 17:27:46 +0200
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied, but this seriously makes eth_mac_addr() completely useless.
Technically, every eth_mac_addr() user in a software/virtual device
should behave the way virtio_net does now.
It therefore probably makes sense to add a boolean arg which when true
elides the netif_running() check then fixup and audit every caller.
next prev parent reply other threads:[~2012-06-28 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 15:27 [patch net-next] virtio_net: allow to change mac when iface is running Jiri Pirko
2012-06-28 4:30 ` David Miller [this message]
2012-06-28 6:35 ` Jiri Pirko
2012-06-28 8:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627.213046.1244710404799995026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=jpirko@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).