From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next] virtio_net: allow to change mac when iface is running Date: Thu, 28 Jun 2012 08:35:25 +0200 Message-ID: <20120628063525.GA1520@minipsycho.orion> References: <1340810866-1017-1-git-send-email-jpirko@redhat.com> <20120627.213046.1244710404799995026.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, brouer@redhat.com, mst@redhat.com To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20120627.213046.1244710404799995026.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org Thu, Jun 28, 2012 at 06:30:46AM CEST, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 27 Jun 2012 17:27:46 +0200 > >> Signed-off-by: Jiri Pirko > >Applied, but this seriously makes eth_mac_addr() completely useless. > >Technically, every eth_mac_addr() user in a software/virtual device >should behave the way virtio_net does now. I guess to. But for some HW devices eth_mac_addr() is needed (when they does not support "life" mac change") > >It therefore probably makes sense to add a boolean arg which when true >elides the netif_running() check then fixup and audit every caller. I was thinking about this. Maybe probably __eth_mac_addr() which does not have netif_running() check and eth_mac_addr() calling netif_running() check and __eth_mac_addr() after that. What do you think? Jirka