From: Francois Romieu <romieu@fr.zoreil.com>
To: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Dept-NX Linux NIC Driver <Dept_NX_Linux_NIC_Driver@qlogic.com>
Subject: Re: [PATCH net-next 2/6] qlge: Stand-up card should not report supporting wol.
Date: Sat, 30 Jun 2012 01:02:00 +0200 [thread overview]
Message-ID: <20120629230200.GA22193@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <5E4F49720D0BAD499EE1F01232234BA877435B23DA@AVEXMB1.qlogic.org>
(linux-zupk.site removed)
Jitendra Kalsaria <jitendra.kalsaria@qlogic.com> :
[...]
> - broken indent
> - netif_err(... "cleared successfully" ...)
> [JK] I don't think so, %s will be replace with "cleared successfully" or with "clear failed" depend upon status value.
I would not netif_err when everything is ok.
[...]
> If I read things correctly, WAKE_MAGIC can not be cleared and it makes no
> difference on the status code. It should be fixed.
>
> [JK] You right, here we are not clearing WAKE_MAGIC but we are making sure that wol is disable when no option is set.
Imho wol should be disabled as well when neither WAKE_MAGIC nor any option
is set at all.
--
Ueimor
next prev parent reply other threads:[~2012-06-29 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:24 [PATCH net-next 0/6] qlge: bug fix Jitendra Kalsaria
2012-06-29 18:24 ` [PATCH net-next 1/6] qlge: Fixed packet transmit errors due to potential driver errors Jitendra Kalsaria
2012-06-29 18:24 ` [PATCH net-next 2/6] qlge: Stand-up card should not report supporting wol Jitendra Kalsaria
2012-06-29 21:37 ` Francois Romieu
2012-06-29 22:40 ` Jitendra Kalsaria
2012-06-29 23:02 ` Francois Romieu [this message]
2012-06-29 18:24 ` [PATCH net-next 3/6] qlge: Garbage values shown in extra info during selftest Jitendra Kalsaria
2012-06-29 18:24 ` [PATCH net-next 4/6] qlge: Fixed double pci free upon tx_ring->q allocation failure Jitendra Kalsaria
2012-06-29 21:37 ` Francois Romieu
2012-06-29 22:48 ` Jitendra Kalsaria
2012-06-29 18:24 ` [PATCH net-next 5/6] qlge: Categorize receive frame errors from firmware Jitendra Kalsaria
2012-06-29 21:38 ` Francois Romieu
2012-06-29 18:24 ` [PATCH net-next 6/6] qlge: Bumped driver version to 1.00.00.31 Jitendra Kalsaria
2012-06-29 21:36 ` [PATCH net-next 0/6] qlge: bug fix Francois Romieu
2012-06-29 21:40 ` Francois Romieu
2012-06-29 22:05 ` Jitendra Kalsaria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629230200.GA22193@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox