From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] dccp: remove unnecessary codes in ipv6.c
Date: Sun, 01 Jul 2012 20:26:43 -0700 (PDT) [thread overview]
Message-ID: <20120701.202643.159397793740641700.davem@davemloft.net> (raw)
In-Reply-To: <1341199140-17135-2-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Mon, 2 Jul 2012 11:19:00 +0800
> - if (opt != NULL) {
> - newnp->opt = ipv6_dup_options(newsk, opt);
> - if (opt != np->opt)
> - sock_kfree_s(sk, opt, opt->tot_len);
> - }
Same bug as your other patch, this leaks options.
next prev parent reply other threads:[~2012-07-02 3:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 3:18 [PATCH net-next 1/2] ipv6: remove unnecessary codes in tcp_ipv6.c roy.qing.li
2012-07-02 3:19 ` [PATCH net-next 2/2] dccp: remove unnecessary codes in ipv6.c roy.qing.li
2012-07-02 3:26 ` David Miller [this message]
2012-07-02 9:08 ` Eric Dumazet
2012-07-05 10:13 ` David Miller
2012-07-02 3:26 ` [PATCH net-next 1/2] ipv6: remove unnecessary codes in tcp_ipv6.c David Miller
2012-07-02 5:23 ` RongQing Li
2012-07-02 5:37 ` David Miller
2012-07-02 8:13 ` Eric Dumazet
2012-07-02 8:54 ` Eric Dumazet
2012-07-02 9:07 ` Eric Dumazet
2012-07-05 10:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120701.202643.159397793740641700.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).