From: David Miller <davem@davemloft.net>
To: linux@8192.net
Cc: fubar@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH v6] bonding support for IPv6 transmit hashing
Date: Mon, 02 Jul 2012 22:14:25 -0700 (PDT) [thread overview]
Message-ID: <20120702.221425.418792617776598841.davem@davemloft.net> (raw)
In-Reply-To: <4FF27CA0.7030708@8192.net>
From: John Eaglesham <linux@8192.net>
Date: Mon, 02 Jul 2012 22:01:20 -0700
> I replaced the mixed tabs and spaces with all tabs when I updated that
> function, but in retrospect the tabs and spaces were likely
> intentional. I will revert.
They were. Don't change existing coding style unless you are certain
it is wrong.
Besides any such changes are completely outside of the scope of
the changes you are making, so you should have left them out in
any event.
next prev parent reply other threads:[~2012-07-03 5:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 7:01 [PATCH v4 0/2] bonding support for IPv6 transmit hashing John Eaglesham
2012-07-01 7:01 ` [PATCH v4 1/2] Add support for IPv6 and bounds checking to transmit hashing functions John Eaglesham
2012-07-01 7:33 ` David Miller
2012-07-01 7:01 ` [PATCH v4 2/2] Update bonding driver documentation to include IPv6 transmit hashing algorithm John Eaglesham
2012-07-01 7:34 ` David Miller
2012-07-01 7:42 ` John Eaglesham
2012-07-01 8:07 ` [PATCH v5] bonding support for IPv6 transmit hashing John Eaglesham
2012-07-01 10:33 ` David Miller
2012-07-01 19:01 ` John Eaglesham
2012-07-01 19:13 ` [PATCH v6] " John Eaglesham
2012-07-02 23:33 ` Jay Vosburgh
2012-07-03 5:01 ` John Eaglesham
2012-07-03 5:14 ` David Miller [this message]
2012-07-03 5:38 ` John Eaglesham
2012-07-03 5:43 ` David Miller
2012-08-21 18:11 ` Jeremy Brookman
2012-08-21 19:19 ` Jay Vosburgh
2012-08-21 22:21 ` John Eaglesham
2012-08-22 12:06 ` Jeremy Brookman
2012-08-23 10:42 ` Jeremy Brookman
2012-08-22 5:12 ` [PATCH v7] bonding: " John Eaglesham
2012-08-22 5:29 ` David Miller
2012-08-22 6:43 ` [PATCH v8] " John Eaglesham
2012-08-23 5:49 ` David Miller
2012-08-23 12:23 ` Jeremy Brookman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702.221425.418792617776598841.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=linux@8192.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).