From: David Miller <davem@davemloft.net>
To: jitendra.kalsaria@qlogic.com
Cc: netdev@vger.kernel.org, ron.mercer@qlogic.com,
Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors.
Date: Tue, 03 Jul 2012 16:14:24 -0700 (PDT) [thread overview]
Message-ID: <20120703.161424.1399041252994063483.davem@davemloft.net> (raw)
In-Reply-To: <5E4F49720D0BAD499EE1F01232234BA877435B2797@AVEXMB1.qlogic.org>
From: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Date: Tue, 3 Jul 2012 12:38:04 -0700
> This patch was intended to remove the line that increments the
> tx_error statistic when the queue is correctly stopped.
It isn't correctly stopped, for the millionth time this condition is a
BUG, there is a kernel log message there because it is a BUG, are you
blind?
if (unlikely(atomic_read(&tx_ring->tx_count) < 2)) {
netif_info(qdev, tx_queued, qdev->ndev,
"%s: shutting down tx queue %d du to lack of resources.\n",
__func__, tx_ring_idx);
netif_stop_subqueue(ndev, tx_ring->wq_id);
atomic_inc(&tx_ring->queue_stopped);
tx_ring->tx_errors++;
return NETDEV_TX_BUSY;
}
THIS CODE BLOCK SHOULD NEVER EXECUTE. It's a driver bug, it should
never happen.
Even if the driver recovers correctly, it's still an error condition.
It's a bug, and bumping the statistic is not wrong at all. You should
find out why this happens, because it's a bug, and it should be fixed.
next prev parent reply other threads:[~2012-07-03 23:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 23:41 [PATCH net 0/7] qlge: bug fix Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 1/7] qlge: Fixed packet transmit errors due to potential driver errors Jitendra Kalsaria
2012-07-03 0:18 ` David Miller
2012-07-03 1:30 ` Jitendra Kalsaria
2012-07-03 1:38 ` David Miller
2012-07-03 1:41 ` David Miller
2012-07-03 3:28 ` Krishna Kumar2
2012-07-03 19:38 ` Jitendra Kalsaria
2012-07-03 20:27 ` Eric Dumazet
2012-07-03 22:22 ` Francois Romieu
2012-07-03 22:33 ` Jitendra Kalsaria
2012-07-03 23:14 ` David Miller [this message]
2012-07-02 23:41 ` [PATCH net 2/7] qlge: Stand-up card should not report supporting wol Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 3/7] qlge: Garbage values shown in extra info during selftest Jitendra Kalsaria
2012-07-05 7:23 ` David Miller
2012-07-05 17:13 ` Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 4/7] qlge: Fixed double pci free upon tx_ring->q allocation failure Jitendra Kalsaria
2012-07-03 1:22 ` Ben Hutchings
2012-07-03 5:56 ` Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 5/7] qlge: Categorize receive frame errors from firmware Jitendra Kalsaria
2012-07-02 23:41 ` [PATCH net 6/7] qlge: refactoring of ethtool stats Jitendra Kalsaria
2012-07-03 1:24 ` Ben Hutchings
2012-07-03 1:26 ` David Miller
2012-07-02 23:41 ` [PATCH net 7/7] qlge: Bumped driver version to 1.00.00.31 Jitendra Kalsaria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703.161424.1399041252994063483.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).