From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>,
Andreas Terzis <aterzis@google.com>, Mark Gordon <msg@google.com>
Subject: Re: [PATCH] netem: fix rate extension and drop accounting
Date: Wed, 4 Jul 2012 00:04:43 +0200 [thread overview]
Message-ID: <20120703220442.GC5064@nuttenaction> (raw)
In-Reply-To: <1341309257.2583.153.camel@edumazet-glaptop>
* Eric Dumazet | 2012-07-03 11:54:17 [+0200]:
>> commit 7bc0f28c7a0c (netem: rate extension) did wrong maths when packet
>> is enqueued while queue is not empty.
>>
>> Result is unexpected cumulative delays
>>
>> # tc qd add dev eth0 root est 1sec 4sec netem delay 200ms rate 100kbit
>> # ping -i 0.1 172.30.42.18
>> PING 172.30.42.18 (172.30.42.18) 56(84) bytes of data.
>> 64 bytes from 172.30.42.18: icmp_req=1 ttl=64 time=208 ms
>> 64 bytes from 172.30.42.18: icmp_req=2 ttl=64 time=424 ms
>> 64 bytes from 172.30.42.18: icmp_req=3 ttl=64 time=838 ms
>> 64 bytes from 172.30.42.18: icmp_req=4 ttl=64 time=1142 ms
>> 64 bytes from 172.30.42.18: icmp_req=5 ttl=64 time=1335 ms
>> 64 bytes from 172.30.42.18: icmp_req=6 ttl=64 time=1949 ms
>> 64 bytes from 172.30.42.18: icmp_req=7 ttl=64 time=2450 ms
>> 64 bytes from 172.30.42.18: icmp_req=8 ttl=64 time=2840 ms
>> 64 bytes from 172.30.42.18: icmp_req=9 ttl=64 time=3121 ms
>> 64 bytes from 172.30.42.18: icmp_req=10 ttl=64 time=3291 ms
>> 64 bytes from 172.30.42.18: icmp_req=11 ttl=64 time=3784 ms
Strange, we test the patch in detail. I will take a look ...
next prev parent reply other threads:[~2012-07-03 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 9:25 [PATCH] netem: fix rate extension and drop accounting Eric Dumazet
2012-07-03 9:54 ` Eric Dumazet
2012-07-03 22:04 ` Hagen Paul Pfeifer [this message]
2012-07-04 5:58 ` Eric Dumazet
2012-07-04 16:51 ` Hagen Paul Pfeifer
2012-07-04 17:23 ` Eric Dumazet
2012-07-04 17:30 ` Hagen Paul Pfeifer
[not found] ` <CAPVr9VP7DniPZj4vZi_myJWfL5JLYKYTXXtrXcKHo9LjEQzjYw@mail.gmail.com>
2012-07-16 23:26 ` Hagen Paul Pfeifer
2012-07-17 5:12 ` Eric Dumazet
[not found] ` <CAPVr9VMCYFO-7uEzO6ft2vpPhVvRgHB3EWJJG62OqGqux1LsZQ@mail.gmail.com>
2012-07-17 17:39 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703220442.GC5064@nuttenaction \
--to=hagen@jauu.net \
--cc=aterzis@google.com \
--cc=eric.dumazet@gmail.com \
--cc=msg@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).