From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 16/19] ipv6: Store route neighbour in rt6_info struct.
Date: Thu, 5 Jul 2012 15:14:13 +0200 [thread overview]
Message-ID: <20120705131413.GD1869@secunet.com> (raw)
In-Reply-To: <20120703.024700.1627207600679312181.davem@davemloft.net>
On Tue, Jul 03, 2012 at 02:47:00AM -0700, David Miller wrote:
>
> This makes for a simplified conversion away from dst_get_neighbour*().
>
> All code outside of ipv6 will use neigh lookups via dst_neigh_lookup*().
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> include/net/ip6_fib.h | 2 ++
> net/ipv6/ip6_output.c | 8 ++++++--
> net/ipv6/route.c | 42 ++++++++++++++++++++++++++----------------
> net/ipv6/xfrm6_policy.c | 1 +
> 4 files changed, 35 insertions(+), 18 deletions(-)
>
> diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
> index a192f78..0fedbd8 100644
> --- a/include/net/ip6_fib.h
> +++ b/include/net/ip6_fib.h
> @@ -86,6 +86,8 @@ struct fib6_table;
> struct rt6_info {
> struct dst_entry dst;
>
> + struct neighbour *n;
> +
This pointer needs to be initialized when we allocate the
rt6_info, otherwise all my testboxes crash during noot.
I'll send a patch to do this.
prev parent reply other threads:[~2012-07-05 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 9:47 [PATCH 16/19] ipv6: Store route neighbour in rt6_info struct David Miller
2012-07-05 13:14 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705131413.GD1869@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).