From: Samuel Ortiz <sameo@linux.intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFC: Prevent NULL deref when getting socket name
Date: Thu, 5 Jul 2012 17:42:02 +0200 [thread overview]
Message-ID: <20120705154202.GI18200@sortiz-mobl> (raw)
In-Reply-To: <20120702182438.GB2010@tuxdriver.com>
Hi John,
On Mon, Jul 02, 2012 at 02:24:38PM -0400, John W. Linville wrote:
> On Sat, Jun 30, 2012 at 11:56:47AM +0200, Sasha Levin wrote:
> > llcp_sock_getname can be called without a device attached to the nfc_llcp_sock.
> >
> > This would lead to the following BUG:
> >
> > [ 362.341807] BUG: unable to handle kernel NULL pointer dereference at (null)
> > [ 362.341815] IP: [<ffffffff836258e5>] llcp_sock_getname+0x75/0xc0
> > [ 362.341818] PGD 31b35067 PUD 30631067 PMD 0
> > [ 362.341821] Oops: 0000 [#627] PREEMPT SMP DEBUG_PAGEALLOC
> > [ 362.341826] CPU 3
> > [ 362.341827] Pid: 7816, comm: trinity-child55 Tainted: G D W 3.5.0-rc4-next-20120628-sasha-00005-g9f23eb7 #479
> > [ 362.341831] RIP: 0010:[<ffffffff836258e5>] [<ffffffff836258e5>] llcp_sock_getname+0x75/0xc0
> > [ 362.341832] RSP: 0018:ffff8800304fde88 EFLAGS: 00010286
> > [ 362.341834] RAX: 0000000000000000 RBX: ffff880033cb8000 RCX: 0000000000000001
> > [ 362.341835] RDX: ffff8800304fdec4 RSI: ffff8800304fdec8 RDI: ffff8800304fdeda
> > [ 362.341836] RBP: ffff8800304fdea8 R08: 7ebcebcb772b7ffb R09: 5fbfcb9c35bdfd53
> > [ 362.341838] R10: 4220020c54326244 R11: 0000000000000246 R12: ffff8800304fdec8
> > [ 362.341839] R13: ffff8800304fdec4 R14: ffff8800304fdec8 R15: 0000000000000044
> > [ 362.341841] FS: 00007effa376e700(0000) GS:ffff880035a00000(0000) knlGS:0000000000000000
> > [ 362.341843] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [ 362.341844] CR2: 0000000000000000 CR3: 0000000030438000 CR4: 00000000000406e0
> > [ 362.341851] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > [ 362.341856] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> > [ 362.341858] Process trinity-child55 (pid: 7816, threadinfo ffff8800304fc000, task ffff880031270000)
> > [ 362.341858] Stack:
> > [ 362.341862] ffff8800304fdea8 ffff880035156780 0000000000000000 0000000000001000
> > [ 362.341865] ffff8800304fdf78 ffffffff83183b40 00000000304fdec8 0000006000000000
> > [ 362.341868] ffff8800304f0027 ffffffff83729649 ffff8800304fdee8 ffff8800304fdf48
> > [ 362.341869] Call Trace:
> > [ 362.341874] [<ffffffff83183b40>] sys_getpeername+0xa0/0x110
> > [ 362.341877] [<ffffffff83729649>] ? _raw_spin_unlock_irq+0x59/0x80
> > [ 362.341882] [<ffffffff810f342b>] ? do_setitimer+0x23b/0x290
> > [ 362.341886] [<ffffffff81985ede>] ? trace_hardirqs_on_thunk+0x3a/0x3f
> > [ 362.341889] [<ffffffff8372a539>] system_call_fastpath+0x16/0x1b
> > [ 362.341921] Code: 84 00 00 00 00 00 b8 b3 ff ff ff 48 85 db 74 54 66 41 c7 04 24 27 00 49 8d 7c 24 12 41 c7 45 00 60 00 00 00 48 8b 83 28 05 00 00 <8b> 00 41 89 44 24 04 0f b6 83 41 05 00 00 41 88 44 24 10 0f b6
> > [ 362.341924] RIP [<ffffffff836258e5>] llcp_sock_getname+0x75/0xc0
> > [ 362.341925] RSP <ffff8800304fde88>
> > [ 362.341926] CR2: 0000000000000000
> > [ 362.341928] ---[ end trace 6d450e935ee18bf3 ]---
> >
> > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
>
> Samuel, I'm taking this one directly.
Thanks. It was already on my for-wireless branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-07-05 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-30 9:56 [PATCH] NFC: Prevent NULL deref when getting socket name Sasha Levin
2012-07-02 18:24 ` John W. Linville
2012-07-05 15:42 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120705154202.GI18200@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).