From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: Initialize the neighbour pointer of rt6_info on allocation
Date: Fri, 6 Jul 2012 08:54:26 +0200 [thread overview]
Message-ID: <20120706065426.GF1869@secunet.com> (raw)
In-Reply-To: <1341501404.2583.4267.camel@edumazet-glaptop>
On Thu, Jul 05, 2012 at 05:16:44PM +0200, Eric Dumazet wrote:
> On Thu, 2012-07-05 at 15:18 +0200, Steffen Klassert wrote:
> >
> > if (rt) {
> > - memset(&rt->rt6i_table, 0,
> > + memset(&rt->n, 0,
> > sizeof(*rt) - sizeof(struct dst_entry));
> > rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
> > }
>
> Hmm, could we find a way to avoid this for future changes ?
>
> We know dst_entry is the first field, so maybe :
>
> if (rt) {
> struct dst_entry *dst = (struct dst_entry *)rt;
>
> memset(dst + 1, 0, sizeof(*rt) - sizeof(*dst));
>
Yes, I think we need to do something like this.
I've just noticed that ip6_blackhole_route, xfrm_alloc_dst,
dn_route_output_slow and dn_route_input_slow have the same issue.
next prev parent reply other threads:[~2012-07-06 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 13:18 [PATCH net-next] ipv6: Initialize the neighbour pointer of rt6_info on allocation Steffen Klassert
2012-07-05 15:16 ` Eric Dumazet
2012-07-06 6:54 ` Steffen Klassert [this message]
2012-07-06 9:16 ` Steffen Klassert
2012-07-05 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706065426.GF1869@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).