netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
	steffen.klassert@secunet.com
Subject: Re: BUG: unable to handle kernel paging request at 00000000d8be176d
Date: Fri, 6 Jul 2012 15:52:45 +0800	[thread overview]
Message-ID: <20120706075245.GA28521@localhost> (raw)
In-Reply-To: <20120706073745.GA28197@localhost>

On Fri, Jul 06, 2012 at 03:37:45PM +0800, Fengguang Wu wrote:
> Hi David,
> 
> > Fengguang Wu can I ask you politely not to quote the quilty patch in
> > it's entirety when reporting bugs?  That screws up my workflow because
> > that patch goes then gets installed as a new patch in patchwork and I
> > have to therefore tick it off every time you report a bug.
> 
> Sorry for that!  Is it fine to _attach_ the referenced patch, or just
> a raw diff?  Or, the commit SHA and subject are all you want to see?

I used git-format-patch which makes a formal patch. How about git-show?
The output will be less like a formal patch, for example:

:       commit c5fb75aafab2fe31353b96cf556c1a689f8ac7e9
:       Author: Fengguang Wu <fengguang.wu@intel.com>
:       Date:   Thu Jun 14 22:36:29 2012 +0800

:           pms: fix build error in pms_probe()
:           
:           drivers/media/video/pms.c: In function ‘pms_probe’:
:           drivers/media/video/pms.c:1047:2: error: implicit declaration of function ‘kzalloc’ [-Werror=implicit-function-declaration]
:           drivers/media/video/pms.c:1047:6: warning: assignment makes pointer from integer without a cast [enabled by default]
:           drivers/media/video/pms.c:1116:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
:           
:           Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

:       diff --git a/drivers/media/video/pms.c b/drivers/media/video/pms.c
:       index af2d908..77f9c92 100644
:       --- a/drivers/media/video/pms.c
:       +++ b/drivers/media/video/pms.c
:       @@ -26,6 +26,7 @@
:        #include <linux/fs.h>
:        #include <linux/kernel.h>
:        #include <linux/mm.h>
:       +#include <linux/slab.h>
:        #include <linux/ioport.h>
:        #include <linux/init.h>
:        #include <linux/mutex.h>

Thanks,
Fengguang

  reply	other threads:[~2012-07-06  7:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 13:48 [net-next:master] general protection fault in __nla_put() wfg
2012-07-05 21:22 ` David Miller
2012-07-06  5:58   ` BUG: unable to handle kernel paging request at 00000000d8be176d Fengguang Wu
2012-07-06  6:13     ` Eric Dumazet
2012-07-06  6:41       ` Eric Dumazet
2012-07-06  6:44         ` David Miller
2012-07-06  6:53           ` Eric Dumazet
2012-07-06  7:03             ` David Miller
2012-07-06  7:19               ` [PATCH net-next] ipv6: fix a bad cast in ip6_dst_lookup_tail() Eric Dumazet
2012-07-06  7:24                 ` David Miller
2012-07-06  6:42       ` BUG: unable to handle kernel paging request at 00000000d8be176d David Miller
2012-07-06  7:37         ` Fengguang Wu
2012-07-06  7:52           ` Fengguang Wu [this message]
2012-07-06  8:29             ` David Miller
2012-07-06  8:34               ` Fengguang Wu
2012-07-06  8:26           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120706075245.GA28521@localhost \
    --to=wfg@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).