netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: fix non-ANSI function declaration warning
@ 2012-07-07 18:47 Emil Goode
  2012-07-07 19:57 ` Ben Hutchings
  0 siblings, 1 reply; 6+ messages in thread
From: Emil Goode @ 2012-07-07 18:47 UTC (permalink / raw)
  To: edumazet, mirq-linux, jpirko, therbert
  Cc: netdev, kernel-janitors, Emil Goode

Sparse is warning about non-ANSI function declaration.
Add void to the parameterless function.

net/core/dev.c:1804:38: warning:
	non-ANSI function declaration of function
	'netif_get_num_default_rss_queues'

Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
 net/core/dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 07c1251..fc6fbce 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1801,7 +1801,7 @@ EXPORT_SYMBOL(netif_set_real_num_rx_queues);
  * This routine should set an upper limit on the number of RSS queues
  * used by default by multiqueue devices.
  */
-int netif_get_num_default_rss_queues()
+int netif_get_num_default_rss_queues(void)
 {
 	return min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
 }
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] net: fix non-ANSI function declaration warning
  2012-07-07 18:47 [PATCH] net: fix non-ANSI function declaration warning Emil Goode
@ 2012-07-07 19:57 ` Ben Hutchings
  2012-07-07 23:12   ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2012-07-07 19:57 UTC (permalink / raw)
  To: Emil Goode
  Cc: edumazet, mirq-linux, jpirko, therbert, netdev, kernel-janitors

On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
> Sparse is warning about non-ANSI function declaration.
> Add void to the parameterless function.
> 
> net/core/dev.c:1804:38: warning:
> 	non-ANSI function declaration of function
> 	'netif_get_num_default_rss_queues'

I also posted a patch for this (and another instance I found).

Ben.

> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>  net/core/dev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 07c1251..fc6fbce 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1801,7 +1801,7 @@ EXPORT_SYMBOL(netif_set_real_num_rx_queues);
>   * This routine should set an upper limit on the number of RSS queues
>   * used by default by multiqueue devices.
>   */
> -int netif_get_num_default_rss_queues()
> +int netif_get_num_default_rss_queues(void)
>  {
>  	return min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
>  }

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net: fix non-ANSI function declaration warning
  2012-07-07 19:57 ` Ben Hutchings
@ 2012-07-07 23:12   ` David Miller
  2012-07-08  0:16     ` Ben Hutchings
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-07-07 23:12 UTC (permalink / raw)
  To: bhutchings
  Cc: emilgoode, edumazet, mirq-linux, jpirko, therbert, netdev,
	kernel-janitors

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 7 Jul 2012 20:57:29 +0100

> On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
>> Sparse is warning about non-ANSI function declaration.
>> Add void to the parameterless function.
>> 
>> net/core/dev.c:1804:38: warning:
>> 	non-ANSI function declaration of function
>> 	'netif_get_num_default_rss_queues'
> 
> I also posted a patch for this (and another instance I found).

But you were asked to fix up the comment formatting in on of those
patches so you need to fix that up and resubmit the entire set.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net: fix non-ANSI function declaration warning
  2012-07-07 23:12   ` David Miller
@ 2012-07-08  0:16     ` Ben Hutchings
  2012-07-08  0:25       ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2012-07-08  0:16 UTC (permalink / raw)
  To: David Miller
  Cc: emilgoode, edumazet, mirq-linux, jpirko, therbert, netdev,
	kernel-janitors

On Sat, 2012-07-07 at 16:12 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Sat, 7 Jul 2012 20:57:29 +0100
> 
> > On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
> >> Sparse is warning about non-ANSI function declaration.
> >> Add void to the parameterless function.
> >> 
> >> net/core/dev.c:1804:38: warning:
> >> 	non-ANSI function declaration of function
> >> 	'netif_get_num_default_rss_queues'
> > 
> > I also posted a patch for this (and another instance I found).
> 
> But you were asked to fix up the comment formatting in on of those
> patches so you need to fix that up and resubmit the entire set.

You have got to be kidding.  I fixed one thing, so I have to fix
another?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net: fix non-ANSI function declaration warning
  2012-07-08  0:16     ` Ben Hutchings
@ 2012-07-08  0:25       ` David Miller
  2012-07-08  0:26         ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-07-08  0:25 UTC (permalink / raw)
  To: bhutchings
  Cc: emilgoode, edumazet, mirq-linux, jpirko, therbert, netdev,
	kernel-janitors

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sun, 8 Jul 2012 01:16:03 +0100

> On Sat, 2012-07-07 at 16:12 -0700, David Miller wrote:
>> From: Ben Hutchings <bhutchings@solarflare.com>
>> Date: Sat, 7 Jul 2012 20:57:29 +0100
>> 
>> > On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
>> >> Sparse is warning about non-ANSI function declaration.
>> >> Add void to the parameterless function.
>> >> 
>> >> net/core/dev.c:1804:38: warning:
>> >> 	non-ANSI function declaration of function
>> >> 	'netif_get_num_default_rss_queues'
>> > 
>> > I also posted a patch for this (and another instance I found).
>> 
>> But you were asked to fix up the comment formatting in on of those
>> patches so you need to fix that up and resubmit the entire set.
> 
> You have got to be kidding.  I fixed one thing, so I have to fix
> another?

You're fixing up a comment, fix it fully.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] net: fix non-ANSI function declaration warning
  2012-07-08  0:25       ` David Miller
@ 2012-07-08  0:26         ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-07-08  0:26 UTC (permalink / raw)
  To: bhutchings
  Cc: emilgoode, edumazet, mirq-linux, jpirko, therbert, netdev,
	kernel-janitors

From: David Miller <davem@davemloft.net>
Date: Sat, 07 Jul 2012 17:25:39 -0700 (PDT)

> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Sun, 8 Jul 2012 01:16:03 +0100
> 
>> On Sat, 2012-07-07 at 16:12 -0700, David Miller wrote:
>>> From: Ben Hutchings <bhutchings@solarflare.com>
>>> Date: Sat, 7 Jul 2012 20:57:29 +0100
>>> 
>>> > On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
>>> >> Sparse is warning about non-ANSI function declaration.
>>> >> Add void to the parameterless function.
>>> >> 
>>> >> net/core/dev.c:1804:38: warning:
>>> >> 	non-ANSI function declaration of function
>>> >> 	'netif_get_num_default_rss_queues'
>>> > 
>>> > I also posted a patch for this (and another instance I found).
>>> 
>>> But you were asked to fix up the comment formatting in on of those
>>> patches so you need to fix that up and resubmit the entire set.
>> 
>> You have got to be kidding.  I fixed one thing, so I have to fix
>> another?
> 
> You're fixing up a comment, fix it fully.

And btw when you don't respond to someone who gives you feedback I
have to assume you agree with them and intend to fix it, and thus I
automatically move all of your patches to changes-requested state
in patchwork and that's the last I will look at them.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-07-08  0:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-07 18:47 [PATCH] net: fix non-ANSI function declaration warning Emil Goode
2012-07-07 19:57 ` Ben Hutchings
2012-07-07 23:12   ` David Miller
2012-07-08  0:16     ` Ben Hutchings
2012-07-08  0:25       ` David Miller
2012-07-08  0:26         ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).