* [PATCH] bcm87xx: disable autonegotiation by default
@ 2012-07-04 10:33 Peter Korsgaard
2012-07-09 7:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Peter Korsgaard @ 2012-07-04 10:33 UTC (permalink / raw)
To: netdev, david.daney, davem; +Cc: Peter Korsgaard
The bcm87xx phys don't support autonegotiation, so don't use it by
default, as otherwise phy_state_machine() will try to enable it (using
c22 requests, which also don't make any sense for the bcm78xx).
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
Tested on a bcm8707, which uses the same id as 8727
drivers/net/phy/bcm87xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
index f5f0562..9a90dcf 100644
--- a/drivers/net/phy/bcm87xx.c
+++ b/drivers/net/phy/bcm87xx.c
@@ -89,6 +89,7 @@ static int bcm87xx_config_init(struct phy_device *phydev)
phydev->supported = SUPPORTED_10000baseR_FEC;
phydev->advertising = ADVERTISED_10000baseR_FEC;
phydev->state = PHY_NOLINK;
+ phydev->autoneg = AUTONEG_DISABLE;
bcm87xx_of_reg_init(phydev);
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcm87xx: disable autonegotiation by default
2012-07-04 10:33 [PATCH] bcm87xx: disable autonegotiation by default Peter Korsgaard
@ 2012-07-09 7:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-09 7:09 UTC (permalink / raw)
To: jacmet; +Cc: netdev, david.daney
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: Wed, 4 Jul 2012 12:33:57 +0200
> The bcm87xx phys don't support autonegotiation, so don't use it by
> default, as otherwise phy_state_machine() will try to enable it (using
> c22 requests, which also don't make any sense for the bcm78xx).
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-09 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-04 10:33 [PATCH] bcm87xx: disable autonegotiation by default Peter Korsgaard
2012-07-09 7:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).