netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH net-next] ipv6: optimize ipv6 addresses compares
Date: Tue, 10 Jul 2012 21:02:21 -0700 (PDT)	[thread overview]
Message-ID: <20120710.210221.559183284956265274.davem@davemloft.net> (raw)
In-Reply-To: <1341978558.3265.6609.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 11 Jul 2012 05:49:18 +0200

> From: Eric Dumazet <edumazet@google.com>
> 
> On 64 bit arches having efficient unaligned accesses (eg x86_64) we can
> use long words to reduce number of instructions for free.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Joe Perches <joe@perches.com>

Maybe we can even be sure that they are 64-bit aligned too?

If there's an embedded u64 in the in6_addr union, they really should
be.

It can't even be an issue in the protocol headers, because in the
socket demux we read the two 32-bit ipv4 addresses in the packet
header as one 64-bit chunk already.

  parent reply	other threads:[~2012-07-11  4:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11  3:49 [PATCH net-next] ipv6: optimize ipv6 addresses compares Eric Dumazet
2012-07-11  3:59 ` Joe Perches
2012-07-11  4:02 ` David Miller [this message]
2012-07-11  4:07   ` Eric Dumazet
2012-07-11  4:13     ` David Miller
2012-07-11  4:44       ` Eric Dumazet
2012-07-11  4:53         ` Eric Dumazet
2012-07-11  5:44         ` David Miller
2012-07-11  4:14 ` Joe Perches
2012-07-11  5:05   ` Eric Dumazet
2012-07-11  6:13     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120710.210221.559183284956265274.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).