From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ogerlitz@mellanox.com, erezsh@mellanox.com,
roland@purestorage.com, netdev@vger.kernel.org,
shlomop@mellanox.com
Subject: Re: [PATCH] IPoIB: fix skb truesize underestimatiom
Date: Tue, 10 Jul 2012 23:37:43 -0700 (PDT) [thread overview]
Message-ID: <20120710.233743.282062793119280863.davem@davemloft.net> (raw)
In-Reply-To: <1341950621.3265.6331.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 10 Jul 2012 22:03:41 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Or Gerlitz reported triggering of WARN_ON_ONCE(delta < len); in
> skb_try_coalesce()
> This warning tracks drivers that incorrectly set skb->truesize
>
> IPoIB indeed allocates a full page to store a fragment, but only
> accounts in skb->truesize the used part of the page (frame length)
>
> This patch fixes skb truesize underestimation, and
> also fixes a performance issue, because RX skbs have not enough tailroom
> to allow IP and TCP stacks to pull their header in skb linear part
> without an expensive call to pskb_expand_head()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
Applied to net, thanks.
prev parent reply other threads:[~2012-07-11 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 20:03 [PATCH] IPoIB: fix skb truesize underestimatiom Eric Dumazet
2012-07-11 6:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710.233743.282062793119280863.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erezsh@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@purestorage.com \
--cc=shlomop@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).