From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: Lin Ming <mlin@ss.pku.edu.cn>,
Massimo Cetra <ctrix+debianbugs@navynet.it>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2] bridge: netfilter: fix skb->nf_bridge NULL panic in br_nf_forward_finish
Date: Tue, 10 Jul 2012 17:41:09 +0900 [thread overview]
Message-ID: <20120710084103.GA27117@verge.net.au> (raw)
In-Reply-To: <alpine.LFD.2.00.1207071322490.5927@ja.ssi.bg>
On Sat, Jul 07, 2012 at 01:27:49PM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Sat, 7 Jul 2012, Lin Ming wrote:
>
> > On Sat, 2012-07-07 at 12:48 +0300, Julian Anastasov wrote:
> > >
> > > Very good. Thanks for tracking and fixing this bug.
> > > Can you send a copy to Simon Horman <horms@verge.net.au>
> > > with correct Subject. As this change can go to stable
> > > kernels you can also improve the comments, for example:
> > >
> > > ipvs: fix oops on NAT reply in br_nf context
> > >
> > > IPVS should not reset skb->nf_bridge in FORWARD hook
> > > by calling nf_reset for NAT replies. It triggers oops in
> > > br_nf_forward_finish.
> > >
> > > [here follows your corrected description including
> > > the stack trace]
> >
> > How about below? Can I have your ACK?
> > I'll resend this patch in another mail.
>
> Very good. You can add my
>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Thanks, I will queue this up in my ipvs tree and see
about getting it included in 3.5
It seems to me that this problem has been present since 2.6.37
and thus is stable material.
prev parent reply other threads:[~2012-07-10 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 0:48 [PATCH v2] bridge: netfilter: fix skb->nf_bridge NULL panic in br_nf_forward_finish Lin Ming
2012-07-07 9:48 ` Julian Anastasov
2012-07-07 10:00 ` Lin Ming
2012-07-07 10:27 ` Julian Anastasov
2012-07-10 8:41 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710084103.GA27117@verge.net.au \
--to=horms@verge.net.au \
--cc=ctrix+debianbugs@navynet.it \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=mlin@ss.pku.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).