* [PATCH iproute2] tc: u32: Fix icmp_code off.
@ 2012-07-10 9:53 Hiroaki SHIMODA
2012-07-10 22:40 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Hiroaki SHIMODA @ 2012-07-10 9:53 UTC (permalink / raw)
To: shemminger; +Cc: netdev
The off of icmp_code is not 20 but 21. Also offmask should be 0 unless
nexthdr+ is specified.
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
---
tc/f_u32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tc/f_u32.c b/tc/f_u32.c
index 975c0b5..7a04634 100644
--- a/tc/f_u32.c
+++ b/tc/f_u32.c
@@ -531,7 +531,7 @@ static int parse_ip(int *argc_p, char ***argv_p, struct tc_u32_sel *sel)
res = parse_u8(&argc, &argv, sel, 20, 0);
} else if (strcmp(*argv, "icmp_code") == 0) {
NEXT_ARG();
- res = parse_u8(&argc, &argv, sel, 20, 1);
+ res = parse_u8(&argc, &argv, sel, 21, 0);
} else
return -1;
--
1.7.8.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] tc: u32: Fix icmp_code off.
2012-07-10 9:53 [PATCH iproute2] tc: u32: Fix icmp_code off Hiroaki SHIMODA
@ 2012-07-10 22:40 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2012-07-10 22:40 UTC (permalink / raw)
To: Hiroaki SHIMODA; +Cc: netdev
On Tue, 10 Jul 2012 18:53:18 +0900
Hiroaki SHIMODA <shimoda.hiroaki@gmail.com> wrote:
> The off of icmp_code is not 20 but 21. Also offmask should be 0 unless
> nexthdr+ is specified.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Both patches applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-10 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-10 9:53 [PATCH iproute2] tc: u32: Fix icmp_code off Hiroaki SHIMODA
2012-07-10 22:40 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).