From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/16] Handle redirects just like PMTU
Date: Thu, 12 Jul 2012 03:58:40 -0700 (PDT) [thread overview]
Message-ID: <20120712.035840.603313259204428604.davem@davemloft.net> (raw)
In-Reply-To: <1342082733.3265.8254.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 12 Jul 2012 10:45:33 +0200
> On Thu, 2012-07-12 at 01:10 -0700, David Miller wrote:
>> As described in my patch series from the other day, we need to
>> rearrange redirect handling so that the local initiators of packets
>> (sockets, tunnels, xfrms, etc.) that implement the protocols compute
>> the route and pass this down into the ipv4/ipv6 routing code.
>>
>> These changes here do so by implementing a new dst_ops->redirect
>> method.
>>
>> No more do we have this funny code that tries several different sets
>> of routing keys to try and figure out which route the redirect should
>> actually be applied to.
>>
>> No more do we have the problem wherein TOS rewriting causes problems
>> for us.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Wow, this looks very good.
>
> I did a quick review and found no obvious problem.
>
> Bye bye ip_rt_redirect(), finally ;)
Great. I'm feeling brave so I'll push this out to net-next after
doing some more build validation.:)
prev parent reply other threads:[~2012-07-12 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 8:10 [PATCH 0/16] Handle redirects just like PMTU David Miller
2012-07-12 8:45 ` Eric Dumazet
2012-07-12 10:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712.035840.603313259204428604.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).