* [PATCH 0/16] Handle redirects just like PMTU
@ 2012-07-12 8:10 David Miller
2012-07-12 8:45 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2012-07-12 8:10 UTC (permalink / raw)
To: netdev
As described in my patch series from the other day, we need to
rearrange redirect handling so that the local initiators of packets
(sockets, tunnels, xfrms, etc.) that implement the protocols compute
the route and pass this down into the ipv4/ipv6 routing code.
These changes here do so by implementing a new dst_ops->redirect
method.
No more do we have this funny code that tries several different sets
of routing keys to try and figure out which route the redirect should
actually be applied to.
No more do we have the problem wherein TOS rewriting causes problems
for us.
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/16] Handle redirects just like PMTU
2012-07-12 8:10 [PATCH 0/16] Handle redirects just like PMTU David Miller
@ 2012-07-12 8:45 ` Eric Dumazet
2012-07-12 10:58 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2012-07-12 8:45 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Thu, 2012-07-12 at 01:10 -0700, David Miller wrote:
> As described in my patch series from the other day, we need to
> rearrange redirect handling so that the local initiators of packets
> (sockets, tunnels, xfrms, etc.) that implement the protocols compute
> the route and pass this down into the ipv4/ipv6 routing code.
>
> These changes here do so by implementing a new dst_ops->redirect
> method.
>
> No more do we have this funny code that tries several different sets
> of routing keys to try and figure out which route the redirect should
> actually be applied to.
>
> No more do we have the problem wherein TOS rewriting causes problems
> for us.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Wow, this looks very good.
I did a quick review and found no obvious problem.
Bye bye ip_rt_redirect(), finally ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/16] Handle redirects just like PMTU
2012-07-12 8:45 ` Eric Dumazet
@ 2012-07-12 10:58 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-07-12 10:58 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 12 Jul 2012 10:45:33 +0200
> On Thu, 2012-07-12 at 01:10 -0700, David Miller wrote:
>> As described in my patch series from the other day, we need to
>> rearrange redirect handling so that the local initiators of packets
>> (sockets, tunnels, xfrms, etc.) that implement the protocols compute
>> the route and pass this down into the ipv4/ipv6 routing code.
>>
>> These changes here do so by implementing a new dst_ops->redirect
>> method.
>>
>> No more do we have this funny code that tries several different sets
>> of routing keys to try and figure out which route the redirect should
>> actually be applied to.
>>
>> No more do we have the problem wherein TOS rewriting causes problems
>> for us.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> Wow, this looks very good.
>
> I did a quick review and found no obvious problem.
>
> Bye bye ip_rt_redirect(), finally ;)
Great. I'm feeling brave so I'll push this out to net-next after
doing some more build validation.:)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-12 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 8:10 [PATCH 0/16] Handle redirects just like PMTU David Miller
2012-07-12 8:45 ` Eric Dumazet
2012-07-12 10:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).