From: Alexander Duyck <alexander.h.duyck@intel.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jeffrey.t.kirsher@intel.com,
edumazet@google.com, bhutchings@solarflare.com,
therbert@google.com, alexander.duyck@gmail.com
Subject: [RFC PATCH 2/2] ixgbe: Add functionality for delaying the MMIO write for Tx
Date: Wed, 11 Jul 2012 17:26:08 -0700 [thread overview]
Message-ID: <20120712002608.27846.31038.stgit@gitlad.jf.intel.com> (raw)
In-Reply-To: <20120712002103.27846.73812.stgit@gitlad.jf.intel.com>
This change makes it so that ixgbe can use the new framework for delaying
the MMIO writes in the transmit path. With this change in place we see a
significant reduction in CPU utilization and increase in overall packets
per second throughput for bulk traffic tests. In addition I have not seen
any increase in latency as a result of this patch.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 22 ++++++++++++++++++++--
1 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 9ec65ee..e9b71b8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -884,6 +884,8 @@ static bool ixgbe_clean_tx_irq(struct ixgbe_q_vector *q_vector,
return true;
}
+ netif_tx_dispatch_queue(txring_txq(tx_ring));
+
netdev_tx_completed_queue(txring_txq(tx_ring),
total_packets, total_bytes);
@@ -5825,6 +5827,22 @@ static void ixgbe_service_task(struct work_struct *work)
ixgbe_service_event_complete(adapter);
}
+static void ixgbe_complete_xmit_frame(struct net_device *dev,
+ unsigned int index)
+{
+ struct ixgbe_adapter *adapter = netdev_priv(dev);
+ struct ixgbe_ring *tx_ring = adapter->tx_ring[index];
+
+ /* notify HW of packet */
+ writel(tx_ring->next_to_use, tx_ring->tail);
+
+ /*
+ * we need this if more than one processor can write to our tail
+ * at a time, it synchronizes IO on IA64/Altix systems
+ */
+ mmiowb();
+}
+
static int ixgbe_tso(struct ixgbe_ring *tx_ring,
struct ixgbe_tx_buffer *first,
u8 *hdr_len)
@@ -6150,8 +6168,7 @@ static void ixgbe_tx_map(struct ixgbe_ring *tx_ring,
tx_ring->next_to_use = i;
- /* notify HW of packet */
- writel(i, tx_ring->tail);
+ netdev_complete_xmit(txring_txq(tx_ring));
return;
dma_error:
@@ -6961,6 +6978,7 @@ static const struct net_device_ops ixgbe_netdev_ops = {
.ndo_open = ixgbe_open,
.ndo_stop = ixgbe_close,
.ndo_start_xmit = ixgbe_xmit_frame,
+ .ndo_complete_xmit = ixgbe_complete_xmit_frame,
#ifdef IXGBE_FCOE
.ndo_select_queue = ixgbe_select_queue,
#endif
next prev parent reply other threads:[~2012-07-12 0:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 0:25 [RFC PATCH 0/2] Coalesce MMIO writes for transmits Alexander Duyck
2012-07-12 0:26 ` [RFC PATCH 1/2] net: Add new network device function to allow for MMIO batching Alexander Duyck
2012-07-12 7:14 ` Eric Dumazet
2012-07-12 15:39 ` Alexander Duyck
2012-07-13 7:38 ` Eric Dumazet
2012-07-13 15:37 ` Alexander Duyck
2012-07-13 15:50 ` Stephen Hemminger
2012-07-13 16:23 ` Eric Dumazet
2012-07-13 7:19 ` Eric Dumazet
2012-07-13 15:49 ` Alexander Duyck
2012-07-13 16:18 ` Eric Dumazet
2012-07-12 0:26 ` Alexander Duyck [this message]
2012-07-12 17:23 ` [RFC PATCH 0/2] Coalesce MMIO writes for transmits Stephen Hemminger
2012-07-12 19:01 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712002608.27846.31038.stgit@gitlad.jf.intel.com \
--to=alexander.h.duyck@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).