netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: hamid jafarian <hamid.jafarian@pdnsoft.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] Ability to compile iproute2 as shared library
Date: Thu, 12 Jul 2012 09:03:30 -0700	[thread overview]
Message-ID: <20120712090330.38dd5b37@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1342093501.19963.11.camel@gol>

On Thu, 12 Jul 2012 16:14:54 +0430
hamid jafarian <hamid.jafarian@pdnsoft.com> wrote:

> Hi,
> 
> This is a try with minimum changes to compile iproute2 as shared
> library.
> Some functions would be used when we compile iproute2 as
> shared library has been defined in "ip.c".
> Also NICs caching strategy has been changed because, when we use
> "libiproute2.so", system NIC list may change, so we should
> re-cache all NICs at each call to NIC manipulation functions.
> Also some call of "exit(*)" changed to "return *".
> HOWTO Make: # export LIBIPROUTE2_SO=y; make
> 
> in attached files there is a simple wrapper to work with 
> libiproute2.so ...
> 

Thank you for the contribution. I can see how this could be useful
in some limited embedded applications, but at this moment it doesn't
seem to be generally worth adding to the upstream code.

The patch does contain some cleanup bits for where the existing
code is not freeing stuff. This should be fixed, independent of
whether library support is added, because it would remove the number
of leaks reported when testing under valgrind. Could you resubmit
that part please.

  reply	other threads:[~2012-07-12 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 11:44 [PATCH iproute2] Ability to compile iproute2 as shared library hamid jafarian
2012-07-12 16:03 ` Stephen Hemminger [this message]
2012-07-12 22:43   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120712090330.38dd5b37@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=hamid.jafarian@pdnsoft.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).