* Re: [PATCH] sch_sfb: Fix missing NULL check
2012-07-12 13:39 [PATCH] sch_sfb: Fix missing NULL check Alan Cox
@ 2012-07-12 13:25 ` David Miller
2012-07-12 13:50 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2012-07-12 13:25 UTC (permalink / raw)
To: alan; +Cc: netdev
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 12 Jul 2012 14:39:11 +0100
> Signed-off-by: Alan Cox <alna@linux.intel.com>
^^^^
I'm truly astonished that you type in signoffs by hand Alan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] sch_sfb: Fix missing NULL check
@ 2012-07-12 13:39 Alan Cox
2012-07-12 13:25 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2012-07-12 13:39 UTC (permalink / raw)
To: netdev
From: Alan Cox <alan@linux.intel.com>
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44461
Signed-off-by: Alan Cox <alna@linux.intel.com>
---
net/sched/sch_sfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c
index 74305c8..30ea467 100644
--- a/net/sched/sch_sfb.c
+++ b/net/sched/sch_sfb.c
@@ -570,6 +570,8 @@ static int sfb_dump(struct Qdisc *sch, struct sk_buff *skb)
sch->qstats.backlog = q->qdisc->qstats.backlog;
opts = nla_nest_start(skb, TCA_OPTIONS);
+ if (opts == NULL)
+ goto nla_put_failure;
if (nla_put(skb, TCA_SFB_PARMS, sizeof(opt), &opt))
goto nla_put_failure;
return nla_nest_end(skb, opts);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sch_sfb: Fix missing NULL check
2012-07-12 13:25 ` David Miller
@ 2012-07-12 13:50 ` Eric Dumazet
2012-07-12 15:33 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2012-07-12 13:50 UTC (permalink / raw)
To: David Miller; +Cc: alan, netdev
On Thu, 2012-07-12 at 06:25 -0700, David Miller wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Thu, 12 Jul 2012 14:39:11 +0100
>
> > Signed-off-by: Alan Cox <alna@linux.intel.com>
> ^^^^
>
> I'm truly astonished that you type in signoffs by hand Alan.
Weel, I do the same ;)
Feel free to add my
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sch_sfb: Fix missing NULL check
2012-07-12 13:50 ` Eric Dumazet
@ 2012-07-12 15:33 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-07-12 15:33 UTC (permalink / raw)
To: eric.dumazet; +Cc: alan, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 12 Jul 2012 15:50:21 +0200
> On Thu, 2012-07-12 at 06:25 -0700, David Miller wrote:
>> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
>> Date: Thu, 12 Jul 2012 14:39:11 +0100
>>
>> > Signed-off-by: Alan Cox <alna@linux.intel.com>
>> ^^^^
>>
>> I'm truly astonished that you type in signoffs by hand Alan.
>
> Weel, I do the same ;)
You guys are weird :-)
> Feel free to add my
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, with signoff typo fixed too :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-12 15:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 13:39 [PATCH] sch_sfb: Fix missing NULL check Alan Cox
2012-07-12 13:25 ` David Miller
2012-07-12 13:50 ` Eric Dumazet
2012-07-12 15:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox