From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: alexander.h.duyck@intel.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, edumazet@google.com,
alexander.duyck@gmail.com
Subject: Re: [v2 PATCH] net: Update alloc frag to reduce get/put page usage and recycle pages
Date: Fri, 13 Jul 2012 02:59:40 -0700 (PDT) [thread overview]
Message-ID: <20120713.025940.1570303494768484854.davem@davemloft.net> (raw)
In-Reply-To: <1342170394.3265.8339.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 13 Jul 2012 11:06:34 +0200
> On Thu, 2012-07-12 at 17:23 -0700, Alexander Duyck wrote:
>> This patch is meant to help improve performance by reducing the number of
>> locked operations required to allocate a frag on x86 and other platforms.
>> This is accomplished by using atomic_set operations on the page count
>> instead of calling get_page and put_page. It is based on work originally
>> provided by Eric Dumazet.
>>
>> In addition it also helps to reduce memory overhead when using TCP. This
>> is done by recycling the page if the only holder of the frame is the
>> netdev_alloc_frag call itself. This can occur when skb heads are stolen by
>> either GRO or TCP and the driver providing the packets is using paged frags
>> to store all of the data for the packets.
>>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-07-13 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 0:23 [v2 PATCH] net: Update alloc frag to reduce get/put page usage and recycle pages Alexander Duyck
2012-07-13 9:06 ` Eric Dumazet
2012-07-13 9:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713.025940.1570303494768484854.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).