From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 02/16] ipv4: Deliver ICMP redirects to sockets too.
Date: Fri, 13 Jul 2012 00:21:40 +0900 [thread overview]
Message-ID: <20120713002140.a441cc979fbdaa505dda2fbe@gmail.com> (raw)
In-Reply-To: <20120712.080653.1463195798230664640.davem@davemloft.net>
On Thu, 12 Jul 2012 08:06:53 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> Date: Thu, 12 Jul 2012 23:58:37 +0900
>
> > So, I think avobe deleted checks about skb->len need to move to
> > ping_err() in case of packets are malformed.
>
> You would be wrong, the check belongs in icmp_socket_deliver().
Ah, OK. Thanks ;)
prev parent reply other threads:[~2012-07-12 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 8:10 [PATCH 02/16] ipv4: Deliver ICMP redirects to sockets too David Miller
2012-07-12 14:58 ` Hiroaki SHIMODA
2012-07-12 15:06 ` David Miller
2012-07-12 15:21 ` Hiroaki SHIMODA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713002140.a441cc979fbdaa505dda2fbe@gmail.com \
--to=shimoda.hiroaki@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).