From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: netdev@vger.kernel.org
Subject: Crash in CIPSO_V4_TAG_LOCAL handling
Date: Fri, 13 Jul 2012 18:08:41 +0100 [thread overview]
Message-ID: <20120713180841.2b202cf8@pyramind.ukuu.org.uk> (raw)
DaveM asked that this goes direct to the list so ...
Looking at some static code analyser output and the results seem valid on
this one:
ip_options_compile called with skb = NULL and an IPOPT_CIPSO option calls
into cipso_v4_validate, which if the option is CIPSO_V4_TAG_LOCAL then
dereferences skb->dev and explodes.
All the other cases appear to correctly avoid or check it versus NULL
Alan
next reply other threads:[~2012-07-13 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 17:08 Alan Cox [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-14 17:22 Crash in CIPSO_V4_TAG_LOCAL handling Lin Ming
2012-07-14 20:08 ` David Miller
2012-07-17 16:25 ` Paul Moore
2012-07-17 17:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713180841.2b202cf8@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).