Re: [PATCH net-next] netem: refine early skb orphaning

[David Miller <davem@davemloft.net>]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sat, 14 Jul 2012 14:53:33 -0700

> On Sat, 14 Jul 2012 15:16:27 +0200
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
>> From: Eric Dumazet <edumazet@google.com>
>> 
>> netem does an early orphaning of skbs. Doing so breaks TCP Small Queue
>> or any mechanism relying on socket sk_wmem_alloc feedback.
>> 
>> Ideally, we should perform this orphaning after the rate module and
>> before the delay module, to mimic what happens on a real link :
>> 
>> skb orphaning is indeed normally done at TX completion, before the
>> transit on the link.
>> 
>> +-------+   +--------+  +---------------+  +-----------------+
>> + Qdisc +---> Device +--> TX completion +--> links / hops    +->
>> +       +   +  xmit  +  + skb orphaning +  + propagation     +
>> +-------+   +--------+  +---------------+  +-----------------+
>>       < rate limiting >                  < delay, drops, reorders >
>> 
>> If netem is used without delay feature (drops, reorders, rate
>> limiting), then we should avoid early skb orphaning, to keep pressure
>> on sockets as long as packets are still in qdisc queue.
>> 
>> Ideally, netem should be refactored to implement delay module
>> as the last stage. Current algorithm merges the two phases
>> (rate limiting + delay) so its not correct.
>> 
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
 ...
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks.