netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gigaset: silence GCC warning for unused 'format_ie'
@ 2012-07-15  9:11 Paul Bolle
  2012-07-17  6:24 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2012-07-15  9:11 UTC (permalink / raw)
  To: Tilman Schmidt, Hansjoerg Lipp, Karsten Keil
  Cc: gigaset307x-common, netdev, linux-kernel

Building Gigaset's CAPI support without Gigaset's debugging enabled
triggers this GCC warning:
    'format_ie' defined but not used [-Wunused-function]

Silence this warning by wrapping format_ie() in an "#ifdef
CONFIG_GIGASET_DEBUG" and "#endif" pair.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 drivers/isdn/gigaset/capi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index 27e4a3e..68452b7 100644
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c
@@ -288,6 +288,7 @@ static inline void dump_rawmsg(enum debuglevel level, const char *tag,
  * format CAPI IE as string
  */
 
+#ifdef CONFIG_GIGASET_DEBUG
 static const char *format_ie(const char *ie)
 {
 	static char result[3 * MAX_FMT_IE_LEN];
@@ -313,6 +314,7 @@ static const char *format_ie(const char *ie)
 	*--pout = 0;
 	return result;
 }
+#endif
 
 /*
  * emit DATA_B3_CONF message
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gigaset: silence GCC warning for unused 'format_ie'
  2012-07-15  9:11 [PATCH] gigaset: silence GCC warning for unused 'format_ie' Paul Bolle
@ 2012-07-17  6:24 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-17  6:24 UTC (permalink / raw)
  To: pebolle; +Cc: tilman, hjlipp, isdn, gigaset307x-common, netdev, linux-kernel

From: Paul Bolle <pebolle@tiscali.nl>
Date: Sun, 15 Jul 2012 11:11:55 +0200

> Building Gigaset's CAPI support without Gigaset's debugging enabled
> triggers this GCC warning:
>     'format_ie' defined but not used [-Wunused-function]
> 
> Silence this warning by wrapping format_ie() in an "#ifdef
> CONFIG_GIGASET_DEBUG" and "#endif" pair.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-17  6:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-15  9:11 [PATCH] gigaset: silence GCC warning for unused 'format_ie' Paul Bolle
2012-07-17  6:24 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).