From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Klassert Subject: Re: iptables CLAMP MSS to PMTU not working? Date: Mon, 16 Jul 2012 09:23:05 +0200 Message-ID: <20120716072305.GJ1869@secunet.com> References: <20120712120021.3dc5cd68@vostro> <20120712132419.50b4acaf@vostro> <20120716084946.67b91a69@vostro> <20120716092058.270f6008@vostro> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org To: Timo Teras Return-path: Received: from a.mx.secunet.com ([195.81.216.161]:46261 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440Ab2GPHXQ (ORCPT ); Mon, 16 Jul 2012 03:23:16 -0400 Content-Disposition: inline In-Reply-To: <20120716092058.270f6008@vostro> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 16, 2012 at 09:20:58AM +0300, Timo Teras wrote: > On Mon, 16 Jul 2012 08:49:46 +0300 Timo Teras wrote: > > > Looking at the changelog, this would likely be side effect of: > > > > commit 261663b0ee2ee8e3947f4c11c1a08be18cd2cea1 > > Author: Steffen Klassert > > Date: Wed Nov 23 02:14:50 2011 +0000 > > > > ipv4: Don't use the cached pmtu informations for input routes > > > > At least from performance side, it would be better if CLAMPMSS to PMTU > > would clamp to the learned, cached mtu. > > Actually, this is worse. Since XFRM is ignored - it breaks > fragmentation for IPsec targets. > > Could this be reverted? I did this patch to avoid to propagate learned PMTU informations. It restores the behaviour we had before we moved the PMTU informations to the inetpeer. Unfortunately CLAMPMSS really wants to have the PMTU informations of an input route, which is not possible any more after this patch. Anyway, this patch seems to be obsolete in the net-next tree, as the cached pmtu informations are back in the route. So we should remove the check for an output route from ipv4_mtu() in the net-next tree. This should bring CLAMPMSS back to work, at least for upcoming kernel versions.