From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] ipv4: Add FIB nexthop exceptions.
Date: Tue, 17 Jul 2012 07:25:34 -0700 (PDT) [thread overview]
Message-ID: <20120717.072534.1265804777758072167.davem@davemloft.net> (raw)
In-Reply-To: <1342533605.2626.680.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 17 Jul 2012 16:00:05 +0200
> On Tue, 2012-07-17 at 06:14 -0700, David Miller wrote:
>> In a regime where we have subnetted route entries, we need a way to
>> store persistent storage about destination specific learned values
>> such as redirects and PMTU values.
>>
>> This is implemented here via nexthop exceptions.
>>
>> The initial implementation is a simple linked list, and can be
>> expanded to a hash table when it is shown to be justified.
>
> Say a typical host uses a single default route, I am trying to convince
> myself it can really use a simple linked list ?
>
> Arent PMTU entries added by messages coming from untrusted sources ?
They are trusted when we validate them at the socket layer, at least
as is done for TCP.
I totally agree that we'll need to adjust the list into something more
sophisticated, but that's an implementation detail rather than
something that requires the actual infrastructure to be redone.
prev parent reply other threads:[~2012-07-17 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 13:14 [PATCH 5/5] ipv4: Add FIB nexthop exceptions David Miller
2012-07-17 14:00 ` Eric Dumazet
2012-07-17 14:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717.072534.1265804777758072167.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox