* [patch] qlge: fix an "&&" vs "||" bug
@ 2012-07-12 14:47 Dan Carpenter
2012-07-12 18:15 ` Jitendra Kalsaria
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-07-12 14:47 UTC (permalink / raw)
To: Anirban Chakraborty
Cc: Jitendra Kalsaria, Ron Mercer, linux-driver, netdev,
kernel-janitors
The condition is always true so WOL will never work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
index 3d4462b..6f316ab 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
@@ -440,7 +440,7 @@ static int ql_set_wol(struct net_device *ndev, struct ethtool_wolinfo *wol)
unsigned short ssys_dev = qdev->pdev->subsystem_device;
/* WOL is only supported for mezz card. */
- if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 ||
+ if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 &&
ssys_dev != QLGE_MEZZ_SSYS_ID_180) {
netif_info(qdev, drv, qdev->ndev,
"WOL is only supported for mezz card\n");
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch] qlge: fix an "&&" vs "||" bug
2012-07-12 14:47 [patch] qlge: fix an "&&" vs "||" bug Dan Carpenter
@ 2012-07-12 18:15 ` Jitendra Kalsaria
2012-07-18 16:42 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jitendra Kalsaria @ 2012-07-12 18:15 UTC (permalink / raw)
To: Dan Carpenter, Anirban Chakraborty
Cc: Ron Mercer, Dept-Eng Linux Driver, netdev,
kernel-janitors@vger.kernel.org
-----Original Message-----
>From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>Sent: Thursday, July 12, 2012 7:47 AM
>To: Anirban Chakraborty
>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; netdev; kernel-janitors@vger.kernel.org
>Subject: [patch] qlge: fix an "&&" vs "||" bug
>
>The condition is always true so WOL will never work.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>index 3d4462b..6f316ab 100644
>--- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>+++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c
>@@ -440,7 +440,7 @@ static int ql_set_wol(struct net_device *ndev, struct ethtool_wolinfo *wol)
> unsigned short ssys_dev = qdev->pdev->subsystem_device;
>
> /* WOL is only supported for mezz card. */
>- if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 ||
>+ if (ssys_dev != QLGE_MEZZ_SSYS_ID_068 &&
> ssys_dev != QLGE_MEZZ_SSYS_ID_180) {
> netif_info(qdev, drv, qdev->ndev,
> "WOL is only supported for mezz card\n");
Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] qlge: fix an "&&" vs "||" bug
2012-07-12 18:15 ` Jitendra Kalsaria
@ 2012-07-18 16:42 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-07-18 16:42 UTC (permalink / raw)
To: jitendra.kalsaria
Cc: dan.carpenter, anirban.chakraborty, ron.mercer, Linux-Driver,
netdev, kernel-janitors
From: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Date: Thu, 12 Jul 2012 11:15:56 -0700
> -----Original Message-----
>>From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
>>Sent: Thursday, July 12, 2012 7:47 AM
>>To: Anirban Chakraborty
>>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; netdev; kernel-janitors@vger.kernel.org
>>Subject: [patch] qlge: fix an "&&" vs "||" bug
>>
>>The condition is always true so WOL will never work.
>>
>>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
...
> Acked-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-18 16:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 14:47 [patch] qlge: fix an "&&" vs "||" bug Dan Carpenter
2012-07-12 18:15 ` Jitendra Kalsaria
2012-07-18 16:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).