netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kkeil@linux-pingi.de
Cc: netdev@vger.kernel.org, rucsoftsec@gmail.com, m.bachem@gmx.de
Subject: Re: [PATCH ISDN] Add check for usb_alloc_urb() result
Date: Wed, 18 Jul 2012 09:44:44 -0700 (PDT)	[thread overview]
Message-ID: <20120718.094444.1720284949125788005.davem@davemloft.net> (raw)
In-Reply-To: <1342169986-24268-1-git-send-email-kkeil@linux-pingi.de>

From: Karsten Keil <kkeil@linux-pingi.de>
Date: Fri, 13 Jul 2012 10:59:46 +0200

> usb_alloc_urb() return value needs to be checked to avoid
> later NULL pointer access.
> Reported by rucsoftsec@gmail.com via bugzilla.kernel.org #44601.
> 
> Signed-off-by: Karsten Keil <kkeil@linux-pingi.de>

Applied.

Please use consistent subject line formatting.  In your previous
patch you provided:

	[PATCH] ISDN:foo bar baz

which I corrected to:

	[PATCH] ISDN: foo bar baz

And for this patch you provided:

	[PATCH ISDN] foo bar baz

which I corrected to:

	[PATCH] ISDN: foo bar baz

Anything in those initial brackets will be removed by the
automated GIT tools, it's a place for text strings you don't
want to end up in the final commit message.

But you want that "ISDN: " prefix there in the end, so please
do not put it in brackets, and please do put a space after
that ":"

Thanks.

      reply	other threads:[~2012-07-18 16:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-13  8:59 [PATCH ISDN] Add check for usb_alloc_urb() result Karsten Keil
2012-07-18 16:44 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718.094444.1720284949125788005.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kkeil@linux-pingi.de \
    --cc=m.bachem@gmx.de \
    --cc=netdev@vger.kernel.org \
    --cc=rucsoftsec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).