From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: joe@perches.com, netdev@vger.kernel.org, andrewmcgr@gmail.com,
dave.taht@gmail.com, therbert@google.com
Subject: Re: [PATCH net-next v4] ipv6: add ipv6_addr_hash() helper
Date: Wed, 18 Jul 2012 11:29:43 -0700 (PDT) [thread overview]
Message-ID: <20120718.112943.524170725976000575.davem@davemloft.net> (raw)
In-Reply-To: <1342635072.2626.3322.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Jul 2012 20:11:12 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Introduce ipv6_addr_hash() helper doing a XOR on all bits
> of an IPv6 address, with an optimized x86_64 version.
>
> Use it in flow dissector, as suggested by Andrew McGregor,
> to reduce hash collision probabilities in fq_codel (and other
> users of flow dissector)
>
> Use it in ip6_tunnel.c and use more bit shuffling, as suggested
> by David Laight, as existing hash was ignoring most of them.
>
> Use it in sunrpc and use more bit shuffling, using hash_32().
>
> Use it in net/ipv6/addrconf.c, using hash_32() as well.
>
> As a cleanup, use it in net/ipv4/tcp_metrics.c
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andrew McGregor <andrewmcgr@gmail.com>
Applied, thanks.
> v4: net/ipv6/addrconf.c part, sorry again David
The more you test my routing cache removal patches, the
more you will be forgiven :-))))))
next prev parent reply other threads:[~2012-07-18 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 12:08 [PATCH net-next] ipv6: add ipv6_addr_hash() helper Eric Dumazet
2012-07-18 12:28 ` David Laight
2012-07-18 14:06 ` Eric Dumazet
2012-07-18 16:15 ` David Miller
2012-07-18 13:57 ` Joe Perches
2012-07-18 14:14 ` Eric Dumazet
2012-07-18 14:27 ` [PATCH net-next v3] " Eric Dumazet
2012-07-18 16:16 ` David Miller
2012-07-18 16:19 ` David Miller
2012-07-18 16:30 ` Eric Dumazet
2012-07-18 18:11 ` [PATCH net-next v4] " Eric Dumazet
2012-07-18 18:29 ` David Miller [this message]
2012-07-18 16:16 ` [PATCH net-next] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718.112943.524170725976000575.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrewmcgr@gmail.com \
--cc=dave.taht@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).