From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
ajackson@solarflare.com, richardcochran@gmail.com
Subject: Re: [PATCH net-next 2/7] sfc: Add channel specific receive_skb handler and post_remove callback
Date: Wed, 18 Jul 2012 11:32:56 -0700 (PDT) [thread overview]
Message-ID: <20120718.113256.279646201702165485.davem@davemloft.net> (raw)
In-Reply-To: <1342635600.2617.54.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 18 Jul 2012 19:20:00 +0100
> + void (*receive_skb)(struct efx_channel *, struct sk_buff *);
This looks to me like a conduit for proprietary features implemented
in a binary-only blob.
I understand how you're using here for PTP, but you're really openning
the door for things I really wouldn't be very happy about.
next prev parent reply other threads:[~2012-07-18 18:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 18:16 pull request: sfc-next 2012-07-18 Ben Hutchings
2012-07-18 18:19 ` [PATCH net-next 1/7] sfc: Add explicit RX queue flag to channel Ben Hutchings
2012-07-18 18:20 ` [PATCH net-next 2/7] sfc: Add channel specific receive_skb handler and post_remove callback Ben Hutchings
2012-07-18 18:32 ` David Miller [this message]
2012-07-18 18:42 ` Ben Hutchings
2012-07-18 18:43 ` David Miller
2012-07-18 18:20 ` [PATCH net-next 3/7] sfc: Allow efx_mcdi_rpc to be called in two parts Ben Hutchings
2012-07-18 18:21 ` [PATCH net-next 4/7] sfc: Add support for IEEE-1588 PTP Ben Hutchings
2012-07-19 14:25 ` Richard Cochran
2012-07-19 14:37 ` Ben Hutchings
2012-07-19 16:05 ` Andrew Jackson
2012-07-20 6:11 ` Richard Cochran
2012-07-19 15:29 ` Stuart Hodgson
2012-07-19 15:43 ` David Miller
2012-07-19 15:50 ` Ben Hutchings
2012-07-20 7:37 ` Richard Cochran
2012-07-20 6:31 ` Richard Cochran
2012-07-20 9:15 ` Stuart Hodgson
2012-07-20 15:30 ` Richard Cochran
2012-07-30 10:03 ` Stuart Hodgson
2012-07-18 18:21 ` [PATCH net-next 5/7] sfc: Support variable-length response to MCDI GET_BOARD_CFG Ben Hutchings
2012-07-18 18:22 ` [PATCH net-next 6/7] sfc: Expose FPGA bitfile partition through MTD Ben Hutchings
2012-07-18 18:22 ` [PATCH net-next 7/7] sfc: Bump version to 3.2 Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718.113256.279646201702165485.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajackson@solarflare.com \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).